Last Comment Bug 794558 - Remove 2 unused vars in mailnews/base/src
: Remove 2 unused vars in mailnews/base/src
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 18.0
Assigned To: Stefan [:stefanh]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-26 10:57 PDT by Stefan [:stefanh]
Modified: 2012-09-28 09:51 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Remove unused vars (and remnants of logging in nsMessengerOSXIntegration.mm) (2.69 KB, patch)
2012-09-26 10:57 PDT, Stefan [:stefanh]
standard8: review+
Details | Diff | Splinter Review

Description Stefan [:stefanh] 2012-09-26 10:57:22 PDT
Created attachment 665052 [details] [diff] [review]
Remove unused vars (and remnants of logging in nsMessengerOSXIntegration.mm)

/Users/stefan/Moz/comm-central/mailnews/base/src/nsMessengerOSXIntegration.mm:66:25: warning: 
      unused variable 'MsgDockCountsLogModule' [-Wunused-variable]
static PRLogModuleInfo *MsgDockCountsLogModule = nullptr;


/Users/stefan/Moz/comm-central/mailnews/base/src/nsMsgStatusFeedback.cpp:33:12: warning: 
      unused variable 'rv' [-Wunused-variable]
  nsresult rv;


Re nsMessengerOSXIntegration.mm: Seems you added logging in http://hg.mozilla.org/comm-central/rev/2acf5df83607 which wasn't 100% removed later on (http://hg.mozilla.org/comm-central/rev/53f0b1dc8aab).
Comment 1 Mark Banner (:standard8, limited time in Dec) 2012-09-26 11:15:31 PDT
Comment on attachment 665052 [details] [diff] [review]
Remove unused vars (and remnants of logging in nsMessengerOSXIntegration.mm)

Looks great, thanks.
Comment 2 Stefan [:stefanh] 2012-09-28 09:51:42 PDT
https://hg.mozilla.org/comm-central/rev/ef74fd9018aa

Note You need to log in before you can comment on or make changes to this bug.