Remove 2 unused vars in mailnews/base/src

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Backend
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
Thunderbird 18.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 665052 [details] [diff] [review]
Remove unused vars (and remnants of logging in nsMessengerOSXIntegration.mm)

/Users/stefan/Moz/comm-central/mailnews/base/src/nsMessengerOSXIntegration.mm:66:25: warning: 
      unused variable 'MsgDockCountsLogModule' [-Wunused-variable]
static PRLogModuleInfo *MsgDockCountsLogModule = nullptr;


/Users/stefan/Moz/comm-central/mailnews/base/src/nsMsgStatusFeedback.cpp:33:12: warning: 
      unused variable 'rv' [-Wunused-variable]
  nsresult rv;


Re nsMessengerOSXIntegration.mm: Seems you added logging in http://hg.mozilla.org/comm-central/rev/2acf5df83607 which wasn't 100% removed later on (http://hg.mozilla.org/comm-central/rev/53f0b1dc8aab).
Attachment #665052 - Flags: review?(mozilla)
Comment on attachment 665052 [details] [diff] [review]
Remove unused vars (and remnants of logging in nsMessengerOSXIntegration.mm)

Looks great, thanks.
Attachment #665052 - Flags: review?(mozilla) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/comm-central/rev/ef74fd9018aa
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.