Closed Bug 794581 Opened 11 years ago Closed 11 years ago

Cannot click submenu items in Jellybean on some phones

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED WORKSFORME
Milestone:
Firefox 18

People

(Reporter: bnicholson, Assigned: sriram)

References

Details

Attachments

(1 file)

Patch
1.33 KB, patch
bnicholson
: review+
Details | Diff | Splinter Review 
STR:
1) Click menu > Tools > Downloads

Expected results:
Downloads can be clicked

Actual results:
Downloads (or any of the other Tools > submenu items) cannot be clicked.

Verified on a Galaxy S with CM10, and on the Android emulator with Jellybean. Both have hardware menu buttons.
Attached patch Patch — — Splinter Review 
This fixes the problem on h/w menu based phones and restores animation where we show a Popup.
Attachment #667542 - Flags: review?(bnicholson)
Comment on attachment 667542 [details] [diff] [review]
Patch

+            if (!activity.hasPermanentMenuKey())
+                activity.closeOptionsMenu();

Add a comment explaining why this check is necessary.
Attachment #667542 - Flags: review?(bnicholson) → review+
Assignee: nobody → sriram
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/33f6113f5a8b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Build ID: 19.0 (2012-10-17) Nightly Channel
Device: Samsung Galaxy Nexus
OS: Android 4.1

Going to menu > Tools > Downloads will open the download manager.This works for each option in Menu > Tools. Setting the bug to Verified WFM.
Status: RESOLVED → VERIFIED
Resolution: FIXED → WORKSFORME
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.