Closed Bug 794598 Opened 8 years ago Closed 8 years ago

Fix antenna detection in FMRadio.cpp

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18
Project Flags:
blocking-basecamp +

People

(Reporter: mwu, Assigned: mwu)

References

Details

(Keywords: regression)

Attachments

(1 file)

Fix antenna/headset detection
425 bytes, patch
cjones
: review+
Details | Diff | Splinter Review 
Bug 791329 broke this but it's easy to fix.
Attachment #665096 - Flags: review?(justin.lebar+bug)
Hi Michael,

Thanks for helping on this issue.
blocking-basecamp: --- → ?
Attachment #665096 - Flags: review?(justin.lebar+bug) → review+
Blocks FM radio so a blocker.
blocking-basecamp: ? → +
https://hg.mozilla.org/mozilla-central/rev/005ccc9a2f2f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
For my edification, why does this change work?
Bug 791329 changed the possible values of mHeadphoneState from SWITCH_STATE_ON / SWITCH_STATE_OFF to SWITCH_STATE_OFF / SWITCH_STATE_HEADSET / SWITCH_STATE_HEADPHONE.
Ah, I see, and crucially my tree does not have that change.  Okay, thanks!
Depends on: 812607
You need to log in before you can comment on or make changes to this bug.