794598 - Fix antenna detection in FMRadio.cpp

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix antenna/headset detection

Bug 791329 broke this but it's easy to fix.

Comment 1

[Marco Chen [:mchen]]

Hi Michael,

Thanks for helping on this issue.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/005ccc9a2f2f

Comment 3

[Andrew Overholt [:overholt]]

Blocks FM radio so a blocker.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/005ccc9a2f2f

Comment 5

[Justin Lebar (not reading bugmail)]

For my edification, why does this change work?

Comment 6

[Michael Wu [:mwu]]

Bug 791329 changed the possible values of mHeadphoneState from SWITCH_STATE_ON / SWITCH_STATE_OFF to SWITCH_STATE_OFF / SWITCH_STATE_HEADSET / SWITCH_STATE_HEADPHONE.

Comment 7

[Justin Lebar (not reading bugmail)]

Ah, I see, and crucially my tree does not have that change.  Okay, thanks!