/crash_trends remove the graph point for 0 data

VERIFIED FIXED in 21

Status

Socorro
Webapp
--
enhancement
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: mbrandt, Assigned: espressive)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 665137 [details]
qa - bug

Is the message "0 total crashes for builds 0 Days old" redundant and can it be removed?

Steps to reproduce:
1. goto /crash_trends
2. Filter on a product with that has only a few crashes represented in the trends

Actual:
On days where there is little to no data, the hover points to view the meta-data on the graph overlap. -- see screenshot.

Suggested:
Either remove the data point for 0 entirely or when there is data (greater than 0 crashes for that day) remove the data point for zero crashes.
(Reporter)

Updated

5 years ago
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

5 years ago
Assignee: nobody → sneethling
Target Milestone: --- → 21

Comment 1

5 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/34173239bfced82dfec3589281869e25b98a1241
Only show tooltip on graph if report count is greater than 0 fixes bug 794637

https://github.com/mozilla/socorro/commit/bda2c40367d9ed0d6cc56803040c5f362a89a550
Merge pull request #846 from ossreleasefeed/crash-trends-remove-tooltip-for-zero-report-counts-794637

Only show tooltip on graph if report count is greater than 0 fixes bug 794637

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 2

5 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/84d6b38a7e5fb39f543f942205a50535aa6cfe4b
Only show tooltip on graph if report count is greater than 0 fixes bug 794637

https://github.com/mozilla/socorro/commit/f1a63bf3c13c7639045b99968cbd62bd3866531d
Merge pull request #847 from ossreleasefeed/crash-trends-remove-tooltip-for-zero-report-counts-794637

Only show tooltip on graph if report count is greater than 0 fixes bug 794637
(Assignee)

Comment 3

5 years ago
Sent and merged: https://github.com/mozilla/socorro/pull/846

TEST CASE
---------

Suggested === true;
(Reporter)

Comment 4

5 years ago
QA verified on stage per comment 0 and comment 3. Thanks Schalk!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.