Closed Bug 794748 Opened 7 years ago Closed 7 years ago

Add mochitest for "min-width:auto" computed-value in a horizontal vs. vertical flexbox

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file, 1 obsolete file)

Per end of bug 666041 comment 113, we should add a mochitest to assert that "min-width:auto" produces a getComputedStyle value of "-moz-min-content", on a flex item in a horizontal flex container.

(and similar for min-height in a vertical flex container, except we don't support -moz-min-content for min-height yet, so that computes to 0 for the moment, and we should assert that with a TODO comment.)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attached patch patch (the mochitest) (obsolete) — Splinter Review
Attachment #673493 - Flags: review?(dbaron)
Comment on attachment 673493 [details] [diff] [review]
patch (the mochitest)

Could you cite the relevant bit of the specification in the test?  (I think that's the " It is intended that this will compute to the ‘min-content’ keyword when the specification defining it (Writing Modes Appendix D) is sufficiently mature." but I'm not sure.)
Attachment #673493 - Flags: review?(dbaron) → review+
Ah yes, I meant to include more documentation. Thanks for catching that.

Added that -- here's the new patch, which I'll land shortly. Carrying forward r+.
Attachment #679331 - Flags: review+
Attachment #673493 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/ed5120ffd118
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.