794748 - Add mochitest for "min-width:auto" computed-value in a horizontal vs. vertical flexbox

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Per end of bug 666041 comment 113, we should add a mochitest to assert that "min-width:auto" produces a getComputedStyle value of "-moz-min-content", on a flex item in a horizontal flex container.

(and similar for min-height in a vertical flex container, except we don't support -moz-min-content for min-height yet, so that computes to 0 for the moment, and we should assert that with a TODO comment.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: patch (the mochitest)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 673493 [details] [diff] [review]
patch (the mochitest)

Could you cite the relevant bit of the specification in the test?  (I think that's the " It is intended that this will compute to the ‘min-content’ keyword when the specification defining it (Writing Modes Appendix D) is sufficiently mature." but I'm not sure.)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: patch v2 (the mochitest, w/ more documentation) r=dbaron

Ah yes, I meant to include more documentation. Thanks for catching that.

Added that -- here's the new patch, which I'll land shortly. Carrying forward r+.

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed5120ffd118

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ed5120ffd118