79483 - Space no longer activates buttons, checkboxes, radiobuttons

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Diego Biurrun]

The space bar does not activate a button when pressed over a button with the
focus. This is important for keyboard navigation in my opinion. 0.8.1 still had
this functionality, 0.9 and todays nightly (build id 200105089 do not.

Steps to reproduce:

1) go to http://www.google.de
2) press tab to give the "Google-Suche" (german for google search) button the
   focus
3) press space
4) nothing happens

Keep up the good work, guys!

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is unfortunately a recent regression....

Thanks for using Mozilla and reporting bugs!

*** This bug has been marked as a duplicate of 53896 ***

Comment 2

[sairuh (rarely reading bugmail)]

v

Comment 3

[Blake Ross]

Let's leave this open.  That other bug has been open for so long, and was only 
really for the scrolling problem.  Now it no longer scrolls, but no longer 
works either.

Comment 4

[Blake Ross]

Cc'ing Rod, but I'd guess this is Arik since it's all broken for other form 
elements (e.g. checkboxes).

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 79530 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

catfood based on all the noise about this being in 0.9

Comment 7

[:deanis74]

Aw, come on - I was first in 79253!  Just kidding.  cc: me.

Comment 8

[Christopher Blizzard (:blizzard)]

Arik, what's going on with this?

Comment 9

[Peter Trudelle]

p2/0.9.1, probably need to take on 0.9 branch too, if broken there.  please add
ETA dates to status whiteboard.

Comment 10

[arik devens]

not sick anymore. will get on this asap. will update whiteboard rsn.

Comment 11

[arik devens]

hmm, afaict the problem here isn't that my change broke the command working but
that atm the focused element is not correct, the buttons and checkboxes are not
being considered focused when the outline is on them but one or more tabs later.

don't think i broke this but i will do a local revert to make sure. either way i
wonder what is causing this...?

Comment 12

[Ferdinand]

*** Bug 80673 has been marked as a duplicate of this bug. ***

Comment 13

[Blake Ross]

*** Bug 80908 has been marked as a duplicate of this bug. ***

Comment 14

[rods (gone)]

yes, the current focused content in the EventStateManager is incorrect. I have 
a simple form example with a submit button and for some reason a "box" frame has 
focus.

Comment 15

[:deanis74]

A long shot, but any chance this is related to bug 81115?

Comment 16

[arik devens]

could be related, i need to look into all of this, i am making progress on the
bug.

Comment 17

[arik devens]

ok i think i know what is going on here, should have a first crack at a patch
(and an explanation) later tonight

Comment 18

[arik devens]

well i do (sorta) know what's going on, i did in fact cause this by my move of
the js spacebar code into the c++, somehow the c++ code is getting the wrong
active element, asked saari for help as my focus knowledge is in no way
extensive.

Comment 19

[arik devens]

Attachment: first crack, works here

Comment 20

[arik devens]

ok, so i moved my code to before the code that prevents default actions from
happening which was stopping the action from taking place. the bit about the
wrong element being focused appears to have been incorrect, anyway seeking r=
and sr= ;-)

Comment 21

[arik devens]

Attachment: new more friendly attempt at all this

Comment 22

[David Hyatt]

Yes, that looks right.  sr=hyatt

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

r=[e-mail]

Comment 24

[arik devens]

commited on trunk, need a= for 0.9

Comment 25

[:deanis74]

Works on Win32 - 2001051908.

Comment 26

[:deanis74]

Whoops, I spoke too soon.  If pressing the button causes the password manager 
dialog to come up ("Save this password?" Yes/Never/No), the Yes button is 
automatically pressed.  Try this at hotmail.com, my.netscape.com, bugzilla login 
page, etc.

Comment 27

[arik devens]

what? ok i will try this out... damnit...

Comment 28

[arik devens]

just tested with my build from last night and it works fine on linux at least...

Comment 29

[Blake Ross]

That's bug 68846; it existed before this fix.  Reclosing.

Comment 30

[arik devens]

need to get into 0.9, not closed yet...

Comment 31

[:deanis74]

Really??  I've never run into this before, and I run on nothing but nightlies, 
but I guess it's all contained in 68846.  Maybe I just haven't gone to a login 
site since February, but I'm pretty sure I have.

Comment 32

[arik devens]

0.9 is closed. drivers said nothing is being checked in to that branch which
means...

Comment 33

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.05.24.0x comm bits on winnt and mac, and an 8pm [5/24] moz
debug on linux.