Closed Bug 794895 Opened 10 years ago Closed 10 years ago

Replace Talos "FAIL:" with "talosError:" rather than "TinderboxPrint:FAIL:", so they appear in TBPL annotated summary

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sheriff-want])

Attachments

(1 file)

Talos outputs failures with the prefix "FAIL:".

buildbotcustom's talos.py then replaces "FAIL:" with "TinderboxPrint:FAIL:", so that TBPL's tinderbox_print parser puts them in the panel lower right of the TBPL UI.

However now that we have bug 790602, we should just get talos.py to prefix with "talosError:" instead, so that TBPL displays them in the annotated summary, rather than hiding them away in the lower tinderbox_print panel.

Depends on bug 794799, since before that lands, the "FAIL:" output will be too noisy, and will swamp the annotated summary box.
Attached patch Patch v1Splinter Review
Attachment #665379 - Flags: review?(catlee)
Blocks: 778688
Attachment #665379 - Flags: review?(catlee) → review+
Depends on: 797324
No longer depends on: 797324
Blocks: 802289
Blocks: 802475
This is now live.
Thank you :-)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.