794898 - Scratchpad should ask for confirmation before closing

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect, P2)

Description

[Mark Goodwin [:mgoodwin]]

I keep on closing scratchpads by accident and losing stuff.  I'm probably not alone in being clumsy; some kind of "are you sure" prompt could be useful here.

Comment 1

[Jesper Hansen]

An alternative could be to keep the text in the scratchpad so if you close it, then it will just be there.

Comment 2

[Anton Kovalyov (:anton)]

Attachment: Trigger promptSave whenever editor is dirty (even without a file)

The proposed patch makes Scratchpad to act the same way--when closing a dirty editor--no matter if there was a file loaded or not. This means it will ask user to save their work and it will put an asterisk in the title when editor is dirty. I think this change should be pretty intuitive for users accustomed to most text editors.

Comment 3

[Heather Arthur [:harth]]

Comment on attachment 672069 [details] [diff] [review]
Trigger promptSave whenever editor is dirty (even without a file)

Review of attachment 672069 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: browser/devtools/scratchpad/test/browser_scratchpad_bug_653427_confirm_close.js
@@ +99,1 @@
>    testUnsavedFileDontSave();

Might just be me, but it took a little bit of time to see what was going on here. Maybe next time add a comment as to why you're calling these twice, or put them them in a new function so it's not repeating.

Comment 4

[Anton Kovalyov (:anton)]

Attachment: Trigger promptSave whenever editor is dirty (even without a file)

Thanks, I've added a comment. Here's a try build: https://tbpl.mozilla.org/?tree=Try&rev=1f919314d292

I will mark this ticket as ready to land once the build finishes.

Comment 5

[Mihai Sucan [:msucan]]

Landed:
https://hg.mozilla.org/integration/fx-team/rev/f25ab1f0fbc3

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f25ab1f0fbc3