794908 - java.lang.NullPointerException: at org.mozilla.gecko.ScreenshotHandler.access$100(ScreenshotHandler.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 18.0a1/20120927: bp-b130ad77-8d2a-4625-ac53-b678f2120927.

java.lang.NullPointerException
	at org.mozilla.gecko.ScreenshotHandler.access$100(ScreenshotHandler.java:27)
	at org.mozilla.gecko.ScreenshotHandler$1.run(ScreenshotHandler.java:309)
	at android.os.Handler.handleCallback(Handler.java:608)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:156)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:31)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.ScreenshotHandler.access%24100%28ScreenshotHandler.java%29

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Straightforward fix; this code is run on a separate thread and the ScreenshotHandler could get wiped out in the middle if a low-memory situation occurs.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Regression from bug 791263

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 665433 [details] [diff] [review]
Patch

Review of attachment 665433 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/563605815bc3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/563605815bc3