Last Comment Bug 794941 - Add a method of exposing chrome globals in the debugger UI
: Add a method of exposing chrome globals in the debugger UI
Status: RESOLVED DUPLICATE of bug 707302
[chrome-debug]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Debugger (show other bugs)
: unspecified
: All All
: P2 normal (vote)
: ---
Assigned To: Victor Porof [:vporof][:vp]
:
Mentors:
Depends on:
Blocks: 740551
  Show dependency treegraph
 
Reported: 2012-09-27 08:05 PDT by Victor Porof [:vporof][:vp]
Modified: 2012-10-02 09:33 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (93.09 KB, patch)
2012-09-27 08:10 PDT, Victor Porof [:vporof][:vp]
no flags Details | Diff | Splinter Review
v2 (94.26 KB, patch)
2012-09-27 10:27 PDT, Victor Porof [:vporof][:vp]
no flags Details | Diff | Splinter Review
v2.1 (93.32 KB, patch)
2012-09-27 11:26 PDT, Victor Porof [:vporof][:vp]
no flags Details | Diff | Splinter Review
v2.2 (93.41 KB, patch)
2012-09-27 12:27 PDT, Victor Porof [:vporof][:vp]
no flags Details | Diff | Splinter Review
v2.3 (93.83 KB, patch)
2012-09-27 13:05 PDT, Victor Porof [:vporof][:vp]
no flags Details | Diff | Splinter Review

Description Victor Porof [:vporof][:vp] 2012-09-27 08:05:23 PDT

    
Comment 1 Victor Porof [:vporof][:vp] 2012-09-27 08:10:30 PDT
Created attachment 665460 [details] [diff] [review]
v1
Comment 2 Victor Porof [:vporof][:vp] 2012-09-27 08:13:19 PDT
Note: the fact that tests still pass is an indicator that the crazy things I did are ok (at least for now), and any cleanup or prettification is due for 707302. That bug will make everything nice and pretty and sparkling and I already started working on it :)
Comment 3 Victor Porof [:vporof][:vp] 2012-09-27 10:27:09 PDT
Created attachment 665531 [details] [diff] [review]
v2

Now changing the "Filter Scripts" label to "Filter Chrome Globals" when appropriate.
Comment 4 Victor Porof [:vporof][:vp] 2012-09-27 11:26:30 PDT
Created attachment 665559 [details] [diff] [review]
v2.1

Apparently I messed up something in webconsole by accident, fact thoroughly shoved in my face by a try push. This fixes everything.
Comment 5 Victor Porof [:vporof][:vp] 2012-09-27 12:27:56 PDT
Created attachment 665585 [details] [diff] [review]
v2.2

Some other dumb stuff was happening.
Comment 6 Victor Porof [:vporof][:vp] 2012-09-27 13:05:11 PDT
Created attachment 665612 [details] [diff] [review]
v2.3

Rebased on top of 755661.
Comment 7 Victor Porof [:vporof][:vp] 2012-10-01 05:20:11 PDT
Since a relatively non-negligible part of this patch (~30kb) is changed anyway in bug 707302, we could dupe this and qfold it with my work in that bug. This has the potential benefit of removing a review request from past's giant queue, but it'll postpone finishing the chrome debugger work for a few days 'till I finish 707302.

Your choice, past.
Comment 8 Panos Astithas [:past] 2012-10-02 03:51:27 PDT
Actually I think this patch isn't strictly required for the first cut of chrome debugging, since Debugger.Object.prototype.hostAnnotations won't be available to help us group module and documents separately. Maybe it would be better to make this bug depend on that, but feel free to do as you see fit.
Comment 9 Victor Porof [:vporof][:vp] 2012-10-02 06:37:40 PDT
(In reply to Panos Astithas [:past] from comment #8)
> Actually I think this patch isn't strictly required for the first cut of
> chrome debugging, since Debugger.Object.prototype.hostAnnotations won't be
> available to help us group module and documents separately. Maybe it would
> be better to make this bug depend on that, but feel free to do as you see
> fit.

Well, I already started working on 707302 4 days ago and I based it on this bug, so making this depend on that would be paradoxical :)

I'll just dupe it since the functionality *is there*, but not pretty.
Comment 10 Victor Porof [:vporof][:vp] 2012-10-02 06:39:31 PDT

*** This bug has been marked as a duplicate of bug 707302 ***
Comment 11 Panos Astithas [:past] 2012-10-02 06:49:54 PDT
(In reply to Victor Porof [:vp] from comment #9)
> (In reply to Panos Astithas [:past] from comment #8)
> > Actually I think this patch isn't strictly required for the first cut of
> > chrome debugging, since Debugger.Object.prototype.hostAnnotations won't be
> > available to help us group module and documents separately. Maybe it would
> > be better to make this bug depend on that, but feel free to do as you see
> > fit.
> 
> Well, I already started working on 707302 4 days ago and I based it on this
> bug, so making this depend on that would be paradoxical :)
> 
> I'll just dupe it since the functionality *is there*, but not pretty.

By "that" I meant the hostAnnotations bug, which I don't know if jimb has filed yet. Duping this is fine though.
Comment 12 Panos Astithas [:past] 2012-10-02 08:59:18 PDT
Comment on attachment 665612 [details] [diff] [review]
v2.3

Clearing the review for now, but do ping me when you have something ready in the other bug.
Comment 13 Victor Porof [:vporof][:vp] 2012-10-02 09:33:34 PDT
(In reply to Panos Astithas [:past] from comment #12)
> Comment on attachment 665612 [details] [diff] [review]
> v2.3
> 
> Clearing the review for now, but do ping me when you have something ready in
> the other bug.

Sure thing.

Note You need to log in before you can comment on or make changes to this bug.