Closed Bug 794941 Opened 8 years ago Closed 8 years ago

Add a method of exposing chrome globals in the debugger UI

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 707302

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [chrome-debug])

Attachments

(1 file, 4 obsolete files)

No description provided.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — Splinter Review
Attachment #665460 - Flags: review?(past)
Note: the fact that tests still pass is an indicator that the crazy things I did are ok (at least for now), and any cleanup or prettification is due for 707302. That bug will make everything nice and pretty and sparkling and I already started working on it :)
Whiteboard: [chrome-debug]
Attached patch v2 (obsolete) — Splinter Review
Now changing the "Filter Scripts" label to "Filter Chrome Globals" when appropriate.
Attachment #665531 - Flags: review?(past)
Attachment #665460 - Attachment is obsolete: true
Attachment #665460 - Flags: review?(past)
Attached patch v2.1 (obsolete) — Splinter Review
Apparently I messed up something in webconsole by accident, fact thoroughly shoved in my face by a try push. This fixes everything.
Attachment #665559 - Flags: review?(past)
Attachment #665531 - Attachment is obsolete: true
Attachment #665531 - Flags: review?(past)
Attached patch v2.2 (obsolete) — Splinter Review
Some other dumb stuff was happening.
Attachment #665559 - Attachment is obsolete: true
Attachment #665559 - Flags: review?(past)
Attachment #665585 - Flags: review?(past)
Attached patch v2.3Splinter Review
Rebased on top of 755661.
Attachment #665585 - Attachment is obsolete: true
Attachment #665585 - Flags: review?(past)
Attachment #665612 - Flags: review?(past)
Since a relatively non-negligible part of this patch (~30kb) is changed anyway in bug 707302, we could dupe this and qfold it with my work in that bug. This has the potential benefit of removing a review request from past's giant queue, but it'll postpone finishing the chrome debugger work for a few days 'till I finish 707302.

Your choice, past.
Priority: -- → P2
Actually I think this patch isn't strictly required for the first cut of chrome debugging, since Debugger.Object.prototype.hostAnnotations won't be available to help us group module and documents separately. Maybe it would be better to make this bug depend on that, but feel free to do as you see fit.
(In reply to Panos Astithas [:past] from comment #8)
> Actually I think this patch isn't strictly required for the first cut of
> chrome debugging, since Debugger.Object.prototype.hostAnnotations won't be
> available to help us group module and documents separately. Maybe it would
> be better to make this bug depend on that, but feel free to do as you see
> fit.

Well, I already started working on 707302 4 days ago and I based it on this bug, so making this depend on that would be paradoxical :)

I'll just dupe it since the functionality *is there*, but not pretty.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 707302
(In reply to Victor Porof [:vp] from comment #9)
> (In reply to Panos Astithas [:past] from comment #8)
> > Actually I think this patch isn't strictly required for the first cut of
> > chrome debugging, since Debugger.Object.prototype.hostAnnotations won't be
> > available to help us group module and documents separately. Maybe it would
> > be better to make this bug depend on that, but feel free to do as you see
> > fit.
> 
> Well, I already started working on 707302 4 days ago and I based it on this
> bug, so making this depend on that would be paradoxical :)
> 
> I'll just dupe it since the functionality *is there*, but not pretty.

By "that" I meant the hostAnnotations bug, which I don't know if jimb has filed yet. Duping this is fine though.
Comment on attachment 665612 [details] [diff] [review]
v2.3

Clearing the review for now, but do ping me when you have something ready in the other bug.
Attachment #665612 - Flags: review?(past)
(In reply to Panos Astithas [:past] from comment #12)
> Comment on attachment 665612 [details] [diff] [review]
> v2.3
> 
> Clearing the review for now, but do ping me when you have something ready in
> the other bug.

Sure thing.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.