794957 - Use imgLoader instead of imgILoader

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Change the c++ callers of imgILoader to use imgLoader.

This changes all the c++ callers of imgILoader to use the concrete type imgLoader.

Comment 1

[Josh Matthews [:jdm]]

I remember checking mxr.mozilla.org/addons and not finding anybody using imgILoader, but this should still be noted for the validator.

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 665475 [details] [diff] [review]
Change the c++ callers of imgILoader to use imgLoader.

Review of attachment 665475 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsContentUtils.cpp
@@ +520,5 @@
>  
>    // Ignore failure and just don't load images
> +  sImgLoader = new imgLoader();
> +  rv = sImgLoader->Init();
> +  if (rv)

if (NS_FAILED(rv))

@@ +521,5 @@
>    // Ignore failure and just don't load images
> +  sImgLoader = new imgLoader();
> +  rv = sImgLoader->Init();
> +  if (rv)
> +    delete sImgLoader;

sImgLoader = nullptr;

@@ +526,5 @@
>    NS_ABORT_IF_FALSE(NS_SUCCEEDED(rv), "Creation should have succeeded");
> +
> +  sPrivateImgLoader = new imgLoader();
> +  rv = sPrivateImgLoader->Init();
> +  if (rv)

if (NS_FAILED(rv))

@@ +527,5 @@
> +
> +  sPrivateImgLoader = new imgLoader();
> +  rv = sPrivateImgLoader->Init();
> +  if (rv)
> +    delete sImgLoader;

delete sPrivateImgLoader;
sPrivateImgLoader = nullptr;

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Change the c++ callers of imgILoader to use imgLoader. v2

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 670773 [details] [diff] [review]
Change the c++ callers of imgILoader to use imgLoader. v2

Review of attachment 670773 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/src/imgLoader.h
@@ +227,5 @@
>  
> +  static imgLoader* Create()
> +  {
> +      imgLoader *loader = new imgLoader();
> +      if (NS_FAILED(loader->Init())) {

Looks like Init() actually can't fail... It should return void (followup, I guess).

Comment 5

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d991794f122

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d991794f122