794959 - Use the right cast in GetAs* functions of union types in new DOM bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Currently we use an old-style cast to ${externalType}, but that's wall-paper over the real problem (and wrong). We need to cast away the const that we get from calling UnionMember.Value(), otherwise for |UnionMember<NonNull<T> >| we might be forcing a cast from |const NonNull<T>&| to |T&|, which doesn't do the right thing.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 665477 [details] [diff] [review]
v1

Ah, excellent.  r=me

Comment 2

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4c544d409bd

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f4c544d409bd

Should this have a test?

Comment 4

[Tanvi Vyas[:tanvi]]

I'm having the same issue.

Comment 5

[Tanvi Vyas[:tanvi]]

Sorry, that was in regards to bug 798004.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Are you also using an unsupported compiler?