Closed Bug 794966 Opened 7 years ago Closed 7 years ago

pymake treats environment variables as := assignments

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Consider the following Makefile:
   FOO += $(BAR)
   BAR := bar
   foo:
           @echo $(FOO)

FOO=foo make -f test.mk

outputs "foo bar" (while make -f test.mk FOO=foo output "foo")

pymake outputs "foo".

The real life case is that we export DLLFLAGS in security/build/Makefile.in, and security/coreconf/WIN32.mk appends -OUT="$@" to it. So the value ends up being whatever was exported + -OUT="", which fails to build.
Attachment #665486 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/5a3024f9a744
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.