795006 - Dont double-print exceptions in run_tests.py

Status: RESOLVED WORKSFORME

(Testing :: Talos, defect)

Description

[Jeff Hammel]

http://hg.mozilla.org/build/talos/file/bfe1c18ec3d1/talos/run_tests.py#l251

This results in output like from
https://bugzilla.mozilla.org/show_bug.cgi?id=794799#c2

    talos_results.add(mytest.runTest(browser_config, test))
  File "/builds/tegra-259/talos-data/talos/ttest.py", line 378, in
  runTest
    test_results.add(browser_log_filename,
  counter_results=counter_results)
  File "/builds/tegra-259/talos-data/talos/results.py", line 120, in
  add
    browserLog = BrowserLogResults(filename=results,
  counter_results=counter_results,
  global_counters=self.global_counters)
  File "/builds/tegra-259/talos-data/talos/results.py", line 319, in
  __init__
    self.parse()
  File "/builds/tegra-259/talos-data/talos/results.py", line 356, in
  parse
    self.error("Could not find %s in browser output: (tokens: %s)" %
  (attr, tokens))
  File "/builds/tegra-259/talos-data/talos/results.py", line 331, in
  error
    raise utils.talosError(message)
talosError: "Could not find beforeLaunchTime in browser output:
  (tokens: ('__startBeforeLaunchTimestamp',
  '__endBeforeLaunchTimestamp')) [browser_output.txt]"
Traceback (most recent call last):
  File "run_tests.py", line 298, in <module>
FAIL: Busted: tp4m
FAIL: Could not find beforeLaunchTime in browser output: (tokens:
  ('__startBeforeLaunchTimestamp', '__endBeforeLaunchTimestamp'))
  [browser_output.txt]
    main()
  File "run_tests.py", line 295, in main
    run_tests(parser)
  File "run_tests.py", line 259, in run_tests
    raise e
utils.talosError: "Could not find beforeLaunchTime in browser output:
  (tokens: ('__startBeforeLaunchTimestamp',
  '__endBeforeLaunchTimestamp')) [browser_output.txt]"
program finished with exit code 1

Instead, we should only print the exception once.  This is doable in
python though I always forget the pattern.

Comment 1

[Julien Pagès (:parkouss)]

Well, I think this is no more an issue. Please reopen the bug if I'm missing something.