795021 - talos should depend on mozfile

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

We use shutil.rmtree some places in talos.  Sometimes it fails:

https://bugzilla.mozilla.org/show_bug.cgi?id=509439

Instead we should use mozfile.rmtree which should be more reliable

Comment 1

[Sambuddha Basu [:sambuddhabasu1]]

I would like to work on this bug. Please assign it to me.

Comment 2

[Sambuddha Basu [:sambuddhabasu1]]

Attachment: Replace shutil.rmtree with mozfile.rmtree

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8375791 [details] [diff] [review]
Replace shutil.rmtree with mozfile.rmtree

Review of attachment 8375791 [details] [diff] [review]:
-----------------------------------------------------------------

we are using mozfile 0.3 in create_talos_zip.py, lets make that 1.1 as indicated in setup.py.  Please address the remaining comments below.

::: create_talos_zip.py
@@ +204,5 @@
>          assert os.path.exists(path), "'%s' not found" % path
>          os.remove(path)
>      for newdir in newdirs:
>          if os.path.exists(newdir):
> +            mozfile.rmtree(newdir)

we do not import mozfile in here, I am fine not adjusting this one.

::: setup.py
@@ +13,5 @@
>  dependencies = ['PyYAML',
>                  'mozlog',
>                  'mozcrash == 0.9',
>                  'mozdevice == 0.26',
> +                'mozfile',

I would like to make this a specific verision, lets use 1.1 as that is the latest version.

::: talos/ffsetup.py
@@ +182,5 @@
>          if tmpdir is None or unpack.lower() == 'true':  #install addon unpacked
>              addon_path = os.path.join(profile_path, 'extensions', 'staged', addon_id)
>              #if an old copy is already installed, remove it
>              if os.path.isdir(addon_path):
> +                mozfile.rmtree(addon_path, ignore_errors=True)

I don't believe we support ignore_errors in mozfile:
https://github.com/mozilla/mozbase/blob/master/mozfile/mozfile/mozfile.py#L120

Comment 4

[Sambuddha Basu [:sambuddhabasu1]]

Attachment: Replace shutil.rmtree with mozfile.rmtree

The necessary changes have been made.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8376334 [details] [diff] [review]
Replace shutil.rmtree with mozfile.rmtree

Review of attachment 8376334 [details] [diff] [review]:
-----------------------------------------------------------------

we need to adjust the hardcoded version of 0.3 in create_talos_zips.py and make it 1.1

Comment 6

[Sambuddha Basu [:sambuddhabasu1]]

Attachment: Replace shutil.rmtree with mozfile.rmtree

Mozfile 1.1 has been included in place of 0.3. Also, shutil.rmtree has been replaced with mozfile.rmtree

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8376445 [details] [diff] [review]
Replace shutil.rmtree with mozfile.rmtree

Review of attachment 8376445 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, I need to verify this works on all platforms.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/c0fb63ff9333

I am planning on deploying talos to mozilla-inbound tomorrow.