795043 - [responsive mode] clicking "Cancel" after clicking on "Add" should cancel the creation of the preset

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[hsablonniere]

You're right. It's now my first priority.

Comment 2

[hsablonniere]

Attachment: [responsive mode] clicking Cancel after clicking on Add should cancel the creation of the preset

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 671867 [details] [diff] [review]
[responsive mode] clicking Cancel after clicking on Add should cancel the creation of the preset

Looks right. Can you test that on try first?

Comment 4

[hsablonniere]

I'm not sure I understood what you want...

Comment 5

[Paul Rouget [:paul]]

(In reply to hsablonniere from comment #4)
> I'm not sure I understood what you want...

See https://wiki.mozilla.org/ReleaseEngineering/TryServer

Ping me on IRC if you need some help.

Comment 6

[Paul Rouget [:paul]]

(Hubert, you should have a commit access now)

Comment 7

[Paul Rouget [:paul]]

Any update on this?

Comment 8

[hsablonniere]

I hope I'll be able to resume this weekend...

Comment 9

[Paul Rouget [:paul]]

I'd very much like to get that in Firefox 19 (merge on monday). Hubert, if you don't have time to push that to try, I can do it for you if you prefer.

Comment 10

[hsablonniere]

I understand. I should have time friday afternoon. I'll let you know if I can't.

Comment 11

[hsablonniere]

https://tbpl.mozilla.org/?tree=Try&rev=c40bf42ff05a

Comment 12

[hsablonniere]

https://tbpl.mozilla.org/?tree=Try&rev=82b1518bb27d

Comment 13

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/e7956f398781

Comment 14

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/e7956f398781