[responsive mode] clicking "Cancel" after clicking on "Add" should cancel the creation of the preset

RESOLVED FIXED in Firefox 19

Status

RESOLVED FIXED
6 years ago
3 months ago

People

(Reporter: paul, Assigned: hubert.sablonniere)

Tracking

Trunk
Firefox 19
x86
All

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

6 years ago
Assignee: nobody → hubert.sablonniere
QA Contact: developer.tools
(Assignee)

Comment 1

6 years ago
You're right. It's now my first priority.
(Assignee)

Comment 2

6 years ago
Created attachment 671867 [details] [diff] [review]
[responsive mode] clicking Cancel after clicking on Add should cancel the creation of the preset
(Assignee)

Updated

6 years ago
Attachment #671867 - Flags: review?(paul)
(Reporter)

Comment 3

6 years ago
Comment on attachment 671867 [details] [diff] [review]
[responsive mode] clicking Cancel after clicking on Add should cancel the creation of the preset

Looks right. Can you test that on try first?
Attachment #671867 - Flags: review?(paul) → review+
(Assignee)

Comment 4

6 years ago
I'm not sure I understood what you want...
(Reporter)

Comment 5

6 years ago
(In reply to hsablonniere from comment #4)
> I'm not sure I understood what you want...

See https://wiki.mozilla.org/ReleaseEngineering/TryServer

Ping me on IRC if you need some help.
(Reporter)

Comment 6

6 years ago
(Hubert, you should have a commit access now)
(Reporter)

Comment 7

6 years ago
Any update on this?
(Assignee)

Comment 8

6 years ago
I hope I'll be able to resume this weekend...
(Reporter)

Comment 9

6 years ago
I'd very much like to get that in Firefox 19 (merge on monday). Hubert, if you don't have time to push that to try, I can do it for you if you prefer.
(Assignee)

Comment 10

6 years ago
I understand. I should have time friday afternoon. I'll let you know if I can't.
(Reporter)

Updated

6 years ago
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/e7956f398781
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e7956f398781
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.