Note: There are a few cases of duplicates in user autocompletion which are being worked on.

the News "Download headers" dialog should use a numeric field for the number of headers to download.

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Networking: NNTP
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({polish})

Trunk
Thunderbird 18.0
polish
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

2.75 KB, patch
aceman
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
The News "Download headers" dialog should use a numeric field for the number of headers to download. Currently it is a plain text field and letters can be input into it.
(Assignee)

Comment 1

5 years ago
Created attachment 665638 [details] [diff] [review]
patch
Attachment #665638 - Flags: ui-review?(bwinton)
Attachment #665638 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

5 years ago
Severity: normal → trivial
Status: NEW → ASSIGNED
Comment on attachment 665638 [details] [diff] [review]
patch

I think we should set the upper limit to the number of messages in the newsgroup.  (Otherwise you can get "There are 5 new messages in this newsgroup.  Download 99999 headers?"  ;)

Aside from that, it seems good.  ui-r=me.
Attachment #665638 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Comment 3

5 years ago
Created attachment 666712 [details] [diff] [review]
patch v2

It probably doesn't hurt but OK, let's make that refinement :)
I still think the dialog does not show up sometimes when it should, but that is a different issue.
Attachment #665638 - Attachment is obsolete: true
Attachment #665638 - Flags: review?(iann_bugzilla)
Attachment #666712 - Flags: review?(Pidgeot18)
Comment on attachment 666712 [details] [diff] [review]
patch v2

Review of attachment 666712 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/news/content/downloadheaders.js
@@ +40,5 @@
>    }
>  
>    numberElement = document.getElementById("number");
>    numberElement.value = nntpServer.maxArticles;
> +  numberElement.max = args.articleCount;

The result of numberElement gets saved into the maximum chunking count for header download, so there are use cases for setting it higher than the number of unretreived articles.

Don't set the max here.
Attachment #666712 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 667046 [details] [diff] [review]
patch v3

OK, thanks.
Attachment #666712 - Attachment is obsolete: true
Attachment #667046 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/0581ea9c4a4f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.