795097 - the News "Download headers" dialog should use a numeric field for the number of headers to download.

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[:aceman]

The News "Download headers" dialog should use a numeric field for the number of headers to download. Currently it is a plain text field and letters can be input into it.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 665638 [details] [diff] [review]
patch

I think we should set the upper limit to the number of messages in the newsgroup.  (Otherwise you can get "There are 5 new messages in this newsgroup.  Download 99999 headers?"  ;)

Aside from that, it seems good.  ui-r=me.

Comment 3

[:aceman]

Attachment: patch v2

It probably doesn't hurt but OK, let's make that refinement :)
I still think the dialog does not show up sometimes when it should, but that is a different issue.

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 666712 [details] [diff] [review]
patch v2

Review of attachment 666712 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/news/content/downloadheaders.js
@@ +40,5 @@
>    }
>  
>    numberElement = document.getElementById("number");
>    numberElement.value = nntpServer.maxArticles;
> +  numberElement.max = args.articleCount;

The result of numberElement gets saved into the maximum chunking count for header download, so there are use cases for setting it higher than the number of unretreived articles.

Don't set the max here.

Comment 5

[:aceman]

Attachment: patch v3

OK, thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/0581ea9c4a4f