Last Comment Bug 795097 - the News "Download headers" dialog should use a numeric field for the number of headers to download.
: the News "Download headers" dialog should use a numeric field for the number ...
Status: RESOLVED FIXED
: polish
Product: MailNews Core
Classification: Components
Component: Networking: NNTP (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 18.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-27 13:53 PDT by :aceman
Modified: 2012-10-02 16:01 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (2.71 KB, patch)
2012-09-27 14:02 PDT, :aceman
bwinton: ui‑review+
Details | Diff | Review
patch v2 (3.47 KB, patch)
2012-10-01 14:20 PDT, :aceman
Pidgeot18: review+
Details | Diff | Review
patch v3 (2.75 KB, patch)
2012-10-02 10:30 PDT, :aceman
acelists: review+
Details | Diff | Review

Description :aceman 2012-09-27 13:53:05 PDT
The News "Download headers" dialog should use a numeric field for the number of headers to download. Currently it is a plain text field and letters can be input into it.
Comment 1 :aceman 2012-09-27 14:02:46 PDT
Created attachment 665638 [details] [diff] [review]
patch
Comment 2 Blake Winton (:bwinton) (:☕️) (PTO 'til London. Find me there for quick answers!) 2012-10-01 13:48:40 PDT
Comment on attachment 665638 [details] [diff] [review]
patch

I think we should set the upper limit to the number of messages in the newsgroup.  (Otherwise you can get "There are 5 new messages in this newsgroup.  Download 99999 headers?"  ;)

Aside from that, it seems good.  ui-r=me.
Comment 3 :aceman 2012-10-01 14:20:51 PDT
Created attachment 666712 [details] [diff] [review]
patch v2

It probably doesn't hurt but OK, let's make that refinement :)
I still think the dialog does not show up sometimes when it should, but that is a different issue.
Comment 4 Joshua Cranmer [:jcranmer] 2012-10-01 14:58:59 PDT
Comment on attachment 666712 [details] [diff] [review]
patch v2

Review of attachment 666712 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/news/content/downloadheaders.js
@@ +40,5 @@
>    }
>  
>    numberElement = document.getElementById("number");
>    numberElement.value = nntpServer.maxArticles;
> +  numberElement.max = args.articleCount;

The result of numberElement gets saved into the maximum chunking count for header download, so there are use cases for setting it higher than the number of unretreived articles.

Don't set the max here.
Comment 5 :aceman 2012-10-02 10:30:35 PDT
Created attachment 667046 [details] [diff] [review]
patch v3

OK, thanks.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-10-02 16:01:24 PDT
https://hg.mozilla.org/comm-central/rev/0581ea9c4a4f

Note You need to log in before you can comment on or make changes to this bug.