795119 - [jsdbg2] Debugger.Object.prototype.evalInGlobal fails to unwrap referent

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

If the 'this' value given to Debugger.Object.prototype.evalInGlobal is a Debugger.Object referring to a global via a wrapper, evalInGlobal will complain that its 'this' is "does not refer to a global object". It should evaluate its argument using the wrapper's target as the global.

Comment 1

[Jim Blandy :jimb]

Attachment: Dereference wrapped 'this' referents in Debugger.Object.prototype.evalInGlobal.

Will r? when it passes try...

Comment 2

[Jim Blandy :jimb]

Try: https://tbpl.mozilla.org/?tree=Try&rev=967ecd6113a1

Comment 3

[Jim Blandy :jimb]

By the way, this patch's tests use functions added in bug 794726.

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 665672 [details] [diff] [review]
Dereference wrapped 'this' referents in Debugger.Object.prototype.evalInGlobal.

Review of attachment 665672 [details] [diff] [review]:
-----------------------------------------------------------------

I think we may have agreed that evalInGlobal should to stay picky on this. r?me again if you disagree.

Comment 5

[Jim Blandy :jimb]

Yes, I agree it should. We should make sure the error thrown makes sense, though, so I may put a new patch to that effect here.

Comment 6

[Jim Blandy :jimb]

Attachment: Complain coherently when evalInGlobal{,withBindings} is passed a CCW to a global, not a global.

Comment 7

[Jim Blandy :jimb]

Try: https://tbpl.mozilla.org/?tree=Try&rev=ea525136085a

Will r? if it looks good.

Comment 8

[Jim Blandy :jimb]

Try does not look good. But I am given to understand that one may expect improved results if one takes care to resolve patch conflicts before submitting one's efforts.

With great optimism:
https://tbpl.mozilla.org/?tree=Try&rev=a5eb7f21b40e

Comment 9

[Luke Wagner [:luke]]

Comment on attachment 669792 [details] [diff] [review]
Complain coherently when evalInGlobal{,withBindings} is passed a CCW to a global, not a global.

Stealing at jimb's request.  Friendly error message and nice test case; r+

Comment 10

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f67e5b827cdf

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f67e5b827cdf