Closed
Bug 795134
Opened 12 years ago
Closed 12 years ago
Remove localStorage when clear private data API is used
Categories
(Core :: General, defect)
Core
General
Tracking
()
People
(Reporter: mounir, Assigned: mounir)
References
Details
(Keywords: feature, Whiteboard: [LOE:S][WebAPI:])
Attachments
(1 file)
12.36 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
The code is ready, we just need to hook it with the correct notification.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
OS: Linux → All
Hardware: x86_64 → All
And Appcache!
CC'ing the necko folks so that they are aware of these plans.
blocking-basecamp: ? → +
Assignee | ||
Comment 2•12 years ago
|
||
I put them together because I will work on those. I could do appcache if needed.
Comment 3•12 years ago
|
||
Appcache is handled already by bug 786299. I'm taking cookies in bug 795203.
Summary: Remove localStorage and cookies when clear private data API is used → Remove localStorage when clear private data API is used
Assignee | ||
Updated•12 years ago
|
Whiteboard: [LOE:S][WebAPI:]
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #666005 -
Flags: review?(bent.mozilla)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [LOE:S][WebAPI:] → [LOE:S][WebAPI:][needs review]
Comment on attachment 666005 [details] [diff] [review]
Patch
Review of attachment 666005 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/src/storage/nsDOMStorage.cpp
@@ +324,3 @@
>
> + uint32_t appId = nsIScriptSecurityManager::NO_APP_ID;
> + bool browserOnly = false;
Nit: No need to initialize these if you're checking for failures below.
Attachment #666005 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Flags: in-testsuite+
Whiteboard: [LOE:S][WebAPI:][needs review] → [LOE:S][WebAPI:]
Target Milestone: --- → mozilla18
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 796110
You need to log in
before you can comment on or make changes to this bug.
Description
•