Closed Bug 795134 Opened 7 years ago Closed 7 years ago

Remove localStorage when clear private data API is used

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Keywords: feature, Whiteboard: [LOE:S][WebAPI:])

Attachments

(1 file)

The code is ready, we just need to hook it with the correct notification.
Depends on: 784378, 794563
OS: Linux → All
Hardware: x86_64 → All
And Appcache!

CC'ing the necko folks so that they are aware of these plans.
blocking-basecamp: ? → +
I put them together because I will work on those. I could do appcache if needed.
Appcache is handled already by bug 786299.  I'm taking cookies in bug 795203.
Summary: Remove localStorage and cookies when clear private data API is used → Remove localStorage when clear private data API is used
Whiteboard: [LOE:S][WebAPI:]
Attached patch PatchSplinter Review
Attachment #666005 - Flags: review?(bent.mozilla)
Whiteboard: [LOE:S][WebAPI:] → [LOE:S][WebAPI:][needs review]
Comment on attachment 666005 [details] [diff] [review]
Patch

Review of attachment 666005 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/src/storage/nsDOMStorage.cpp
@@ +324,3 @@
>  
> +    uint32_t appId = nsIScriptSecurityManager::NO_APP_ID;
> +    bool browserOnly = false;

Nit: No need to initialize these if you're checking for failures below.
Attachment #666005 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e63fa4a848a
Flags: in-testsuite+
Whiteboard: [LOE:S][WebAPI:][needs review] → [LOE:S][WebAPI:]
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/3e63fa4a848a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 796911
Depends on: 826924
You need to log in before you can comment on or make changes to this bug.