795135 - [Azure] Cairo paths helper not restoring transforms

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

The cairo path helper CairoTempMatrix doesn't restore matrices as it should.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix CairoTempMatrix restore

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 665670 [details] [diff] [review]
Fix CairoTempMatrix restore

Review of attachment 665670 [details] [diff] [review]:
-----------------------------------------------------------------

tears and weeping

Comment 3

[Mozilla RelEng Bot]

Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 90 total builds):
    success: 80
    warnings: 10
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7c4a2915b413

Comment 4

[Mozilla RelEng Bot]

Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 94 total builds):
    success: 83
    warnings: 11
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7c4a2915b413

Comment 5

[Mozilla RelEng Bot]

Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 95 total builds):
    success: 83
    warnings: 12
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7c4a2915b413

Comment 6

[Mozilla RelEng Bot]

Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 97 total builds):
    success: 84
    warnings: 13
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7c4a2915b413

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa73f5544e07

Should this have a test?

Comment 8

[Joe Drew (not getting mail)]

IIRC it broke existing tests when azure content was turned on.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aa73f5544e07

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

It turns out that this is what regressed a few Canvas 2D tests, like

http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.transform.2.html

on various platforms. Bisection found

changeset:   108853:aa73f5544e07
user:        Anthony Jones <[e-mail]>
date:        Mon Oct 01 22:12:13 2012 -0400
summary:     Bug 795135 - Fix CairoTempMatrix restore. r=joe

Again I apologize for having accidentally disabled canvas tests for a few weeks. They are reenabled now, but with these few sub-tests commented out. See bug 800658.

Comment 11

[Benoit Jacob [:bjacob] (mostly away)]

Anthony, I'm not really competent to debug this. Can I ask you to take care of it?