Closed Bug 795135 Opened 7 years ago Closed 7 years ago

[Azure] Cairo paths helper not restoring transforms

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: ajones, Assigned: ajones)

References

Details

Attachments

(1 file)

The cairo path helper CairoTempMatrix doesn't restore matrices as it should.
Assignee: nobody → ajones
Comment on attachment 665670 [details] [diff] [review]
Fix CairoTempMatrix restore

Review of attachment 665670 [details] [diff] [review]:
-----------------------------------------------------------------

tears and weeping
Attachment #665670 - Flags: review?(joe) → review+
Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 90 total builds):
    success: 80
    warnings: 10
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-7c4a2915b413
Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 94 total builds):
    success: 83
    warnings: 11
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-7c4a2915b413
Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 95 total builds):
    success: 83
    warnings: 12
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-7c4a2915b413
Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 97 total builds):
    success: 84
    warnings: 13
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-7c4a2915b413
Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa73f5544e07

Should this have a test?
Flags: in-testsuite?
Keywords: checkin-needed
IIRC it broke existing tests when azure content was turned on.
Flags: in-testsuite? → in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/aa73f5544e07
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
It turns out that this is what regressed a few Canvas 2D tests, like

http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.transform.2.html

on various platforms. Bisection found

changeset:   108853:aa73f5544e07
user:        Anthony Jones <ajones@mozilla.com>
date:        Mon Oct 01 22:12:13 2012 -0400
summary:     Bug 795135 - Fix CairoTempMatrix restore. r=joe

Again I apologize for having accidentally disabled canvas tests for a few weeks. They are reenabled now, but with these few sub-tests commented out. See bug 800658.
Blocks: 800658
No longer blocks: 800658
Depends on: 800658
Anthony, I'm not really competent to debug this. Can I ask you to take care of it?
You need to log in before you can comment on or make changes to this bug.