79516 - File type description contains garbage characters when initiating download on non-English OS

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Jon Rubin]

Trunk build 2001050406.  Found on WinMe-Ja.

When downloading a file, the first sentence in the download dialog window says 
"You have chosen to download a file of type:".  If downloading on a non-English 
system such as Japanese WinMe, this sentence is immediately followed by garbage 
characters.  To reproduce:

1) Go to a download site, such as download.cnet.com/downloads.
2) Initiate a download.  The download dialogue window will open; the garbage 
characters appear as described above.

Comment 1

[nhottanscp]

Please attach a screen shot.

Comment 2

[Jon Rubin]

Attachment: Image shows garbage chars.

Comment 3

[hirata masakazu]

seems to be related to bug bug 78029

Comment 4

[nhottanscp]

Reassign to pchen, cc to av.

Comment 5

[Andreas Becker]

Changing QA contact to [e-mail].

Comment 6

[Jaime Rodriguez, Jr.]

Paul - Why is this future? Pls consider for M0.9.1, but it should definitely be 
fixed by M0.9.2.

Comment 7

[Jaime Rodriguez, Jr.]

Adding Vishy to cc: list. Vishy - This doesn't look good. Why is it marked
Future, and not MO.9.2?

Marking as RTM and nscatfood, because I don't think we should ship a product
this way. The user can not tell what they are downloading. In the world of
viruses, i would not be secure using this product.

Comment 8

[Jaime Rodriguez, Jr.]

Per Monday's PDT, we believe this should be fixed for RTM. Moving to M0.9.2 | 
P2.

Comment 9

[Viswanath Ramachandran]

Frank, we may need help to reproduce this with a debug build on a Japanese OS
system. No one in my group has a Japanese system. Could someone in your group
take this bug? thanks, Vishy

Comment 10

[Roy Yokoyama]

Attachment: Use MultiByteToWideChar() to convert to Unicode

Comment 11

[Roy Yokoyama]

pchen: can you you assign this bug to me? Vishy, Frank and myself 
talked yesterday with regard to this bug. Thank you.

Comment 12

[Viswanath Ramachandran]

-> yokoyama. Thanks for taking & fixing this! Is there similar change needed for
other OS (Mac/Linux) or will this be windows only. Paul can you r= the patch. 

Comment 13

[Roy Yokoyama]

Attachment: Adding NULL terminator.

Comment 14

[Roy Yokoyama]

>Is there similar change needed for
>other OS (Mac/Linux)
Potentially in other platforms as well, 
but by quickly looking at Unix and Mac files
they seems ok.  We may want to confirm this
with iQA for respective platforms.  
Andreas, can check?

>will this be windows only.
Yes, this fix is windows only.

I posted a better patch (adding NULL terminator to Unicode string)

Comment 15

[Roy Yokoyama]

Attachment: Fixing potential memory overflow.

Comment 16

[Roy Yokoyama]

ftang: thanks for checking my code. Please review. thanks

Comment 17

[Frank Tang]

r=ftang

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail]

Comment 19

[Alec Flett]

sr=alecf

Comment 20

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 21

[Roy Yokoyama]

checked-in

Comment 22

[Jon Rubin]

VERIFIED in 062506 Trunk build using WinMe-Ja.