795162 - B2G Wifi: Reuse systemlib's property_get

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Hubert Figuiere [:hub]]

WifiWorker import ctype and reimplement get_property from libcutils

Instead it should just do 

XPCOMUtils.defineLazyGetter(this, "libcutils", function () {
  Cu.import("resource://gre/modules/systemlibs.js");
  return libcutils;
});

(need bug 795161)

Comment 1

[Hubert Figuiere [:hub]]

Attachment: Bug 795162 - Use systemlibs.js for WifiWorker.

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 665695 [details] [diff] [review]
Bug 795162 - Use systemlibs.js for WifiWorker.

Review of attachment 665695 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/WifiWorker.js
@@ +41,4 @@
>  // expected results).
>  var WifiManager = (function() {
>    function getSdkVersionAndDevice() {
> +    Cu.import("resource://gre/modules/systemlibs.js");

I thought you were going to do a lazy getter? :)

I guess it doesn't matter so much since Cu.import() is nilpotent for subsequent calls, plus we're only calling this function once.

@@ +42,5 @@
>  var WifiManager = (function() {
>    function getSdkVersionAndDevice() {
> +    Cu.import("resource://gre/modules/systemlibs.js");
> +    return { sdkVersion: parseInt(libcutils
> +                                  .property_get("ro.build.version.sdk")),

Always pass the base to parseInt(). IOW, parseInt(x, 10);

Also maybe a more elegant way to get around this overlong line would be to define sdkVersion as a local variable above the `return` statement.

r=me with that.

Comment 3

[Hubert Figuiere [:hub]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22df14239cfb

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/22df14239cfb