795173 - [jsdbg2] Debugger.Object.prototype.evalInGlobalWithBindings passes a bad 'this' value

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

If g is a Debugger.Object referring to a global object, then |g.evalInGlobalWithBindings(code, bindings)| should evaluate |code| with g's referent as its 'this' value. Instead, it supplies the bindings scope object as the 'this' value.

Comment 1

[Jim Blandy :jimb]

Attachment: Make Debugger.Object.prototype.evalInGlobalWithBindings pass the right 'this' value.

This also adds a test for Debugger.Frame.prototype.evalWithBindings, to
make sure it puts new variables on the right object; I couldn't find any
existing tests for the non-strict case (Frame-evalWithBindings-11.js
handles the strict mode case).

Comment 2

[Jim Blandy :jimb]

Try: https://tbpl.mozilla.org/?tree=Try&rev=aa9b73b443c1
(Will r? if it looks good.)

Comment 3

[Jim Blandy :jimb]

Comment on attachment 665714 [details] [diff] [review]
Make Debugger.Object.prototype.evalInGlobalWithBindings pass the right 'this' value.

Looked good.

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 665714 [details] [diff] [review]
Make Debugger.Object.prototype.evalInGlobalWithBindings pass the right 'this' value.

Review of attachment 665714 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. Thanks.

Comment 5

[Jim Blandy :jimb]

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e061305143b6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e061305143b6