Closed
Bug 795201
Opened 14 years ago
Closed 14 years ago
nsIDOMDeviceStorage needs to expose real paths to gecko
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikeh, Assigned: dougt)
Details
Attachments
(1 file)
|
4.55 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Comment 1•14 years ago
|
||
Mike, do you have any suggestions on the api? For example, if I add a read-only attribute nsIFile, will that be okay? Are you only using this from C++?
| Reporter | ||
Comment 2•14 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #1)
> Mike, do you have any suggestions on the api? For example, if I add a
> read-only attribute nsIFile, will that be okay? Are you only using this
> from C++?
Doug: yep, only from C++. A read-only attribute would do the trick--something I can get into an ns*String to which I can .Append(videoFilename).
| Assignee | ||
Comment 3•14 years ago
|
||
Just to be completely clear --
suppose videos are stored at:
/Users/dougt/Movies
You wouldn't mind having that entire path, right?
| Reporter | ||
Comment 4•14 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #3)
> Just to be completely clear --
>
> suppose videos are stored at:
>
> /Users/dougt/Movies
>
> You wouldn't mind having that entire path, right?
Correct. Not sure how you feel about a trailing '/', but that would make my life easier too.
It would be nice if we could hand you ("video", "foo.mp4"), and then get back "/Users/dougt/Movies/foo.mp4".
| Assignee | ||
Comment 6•14 years ago
|
||
mikeh, can you give this a try?
Attachment #666014 -
Flags: review?(jonas)
Comment on attachment 666014 [details] [diff] [review]
patch v.1
Review of attachment 666014 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/devicestorage/DeviceStorageRequestChild.cpp
@@ +55,5 @@
> BlobChild* actor = static_cast<BlobChild*>(r.blobChild());
> nsCOMPtr<nsIDOMBlob> blob = actor->GetBlob();
>
> + nsCOMPtr<nsIDOMFile> file = do_QueryInterface(blob);
> + jsval result = InterfaceToJsval(mRequest->GetOwner(), file, &NS_GET_IID(nsIDOMFile));
Why do you need this? Interface flattening should ensure that it doesn't matter if you wrap an nsIDOMBlob or an nsIDOMFile
Attachment #666014 -
Flags: review?(jonas) → review+
| Assignee | ||
Comment 8•14 years ago
|
||
Comment on attachment 666014 [details] [diff] [review]
patch v.1
nope... i don't want those changes -- part of something else.
| Assignee | ||
Comment 9•14 years ago
|
||
bad form.
This patch landed with bug 776062 without any of the fix ups that Jonas suggested.
| Assignee | ||
Comment 10•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•