795201 - nsIDOMDeviceStorage needs to expose real paths to gecko

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[Doug Turner (:dougt)]

Mike, do you have any suggestions on the api?  For example, if I add a read-only attribute nsIFile, will that be okay?  Are you only using this from C++?

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Doug Turner (:dougt) from comment #1)
> Mike, do you have any suggestions on the api?  For example, if I add a
> read-only attribute nsIFile, will that be okay?  Are you only using this
> from C++?

Doug: yep, only from C++.  A read-only attribute would do the trick--something I can get into an ns*String to which I can .Append(videoFilename).

Comment 3

[Doug Turner (:dougt)]

Just to be completely clear -- 

suppose videos are stored at:

/Users/dougt/Movies

You wouldn't mind having that entire path, right?

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Doug Turner (:dougt) from comment #3)
> Just to be completely clear -- 
> 
> suppose videos are stored at:
> 
> /Users/dougt/Movies
> 
> You wouldn't mind having that entire path, right?

Correct.  Not sure how you feel about a trailing '/', but that would make my life easier too.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It would be nice if we could hand you ("video", "foo.mp4"), and then get back "/Users/dougt/Movies/foo.mp4".

Comment 6

[Doug Turner (:dougt)]

Attachment: patch v.1

mikeh, can you give this a try?

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 666014 [details] [diff] [review]
patch v.1

Review of attachment 666014 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/DeviceStorageRequestChild.cpp
@@ +55,5 @@
>        BlobChild* actor = static_cast<BlobChild*>(r.blobChild());
>        nsCOMPtr<nsIDOMBlob> blob = actor->GetBlob();
>  
> +      nsCOMPtr<nsIDOMFile> file = do_QueryInterface(blob);
> +      jsval result = InterfaceToJsval(mRequest->GetOwner(), file, &NS_GET_IID(nsIDOMFile));

Why do you need this? Interface flattening should ensure that it doesn't matter if you wrap an nsIDOMBlob or an nsIDOMFile

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 666014 [details] [diff] [review]
patch v.1

nope... i don't want those changes -- part of something else.

Comment 9

[Doug Turner (:dougt)]

bad form.


This patch landed with bug 776062 without any of the fix ups that Jonas suggested.

Comment 10

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/68c4c30ff6f0