795224 - Nightly 27/9: no more backspace nor arrows on the deck Asus Transformer

Status: RESOLVED FIXED

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

Installed nightly build 27/09 to solve problem with bug 669361. Bug solved.


Actual results:

Backspace and arrows keys on the deck are not recognized


Expected results:

Shoud be recognized

Comment 1

[Alex Keybl [:akeybl]]

We don't plan to take bug 669361 for FF16, so no need to track there.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking for 17, if bug 669361 is uplifted to 17, we'll want this too.

Comment 3

[Makoto Kato [:m_kato]]

Created attachment 666460 [details] [diff] [review]
fix

onKeyDown/onKeyUp/onKeyMultiple shouldn't return false

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 666460 [details] [diff] [review]
fix

Review of attachment 666460 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac5c29ec176b

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ac5c29ec176b

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 666460 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 669361
User impact if declined: Asus Transformer's hardware keyboards will always have en-US key layouts, regardless of user locale.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): If bug 669361 is uplifted to fix Asus Transformer's hardware keyboard layouts, then this patch must also bug uplifted (to fix a regression from bug 669361).
String or UUID changes made by this patch: N/A

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 666460 [details] [diff] [review]
fix

approving for aurora since this is needed by the fix in bug 669361, please land before monday oct 8th merge.

Comment 9

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4411e891e61f