Closed
Bug 795227
Opened 13 years ago
Closed 13 years ago
ParallelArray should check length range like Array
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: shu, Assigned: shu)
Details
Attachments
(1 file)
|
15.99 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Currently ParallelArray operations that take a length as an argument, such as the comprehension form, simply coerce the argument to uint32_t. It should report RangeError when the argument is out of uint32_t range and TypeError when it is NaN.
|
Assignee | |
Updated•13 years ago
|
Severity: normal → minor
OS: Linux → All
|
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: general → shu
|
|
Assignee | |
Updated•13 years ago
|
Flags: in-testsuite+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #665807 -
Flags: review?(dvander)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Erratum: MOZ_DOUBLE_IS_NaN should be !MOZ_DOUBLE_IS_FINITE
Comment on attachment 665807 [details] [diff] [review]
fix and testcases
It might be nicer if the ToUint32 + malformed reporting was combined into one function.
Attachment #665807 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to David Anderson [:dvander] from comment #3)
> Comment on attachment 665807 [details] [diff] [review]
> fix and testcases
>
> It might be nicer if the ToUint32 + malformed reporting was combined into
> one function.
That makes things less flexible. Not every malformed input is an error. If I use .get on a PA with a malformed index vector, undefined is returned. That behavior could change in the future, but that's what it is now.
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•