795249 - [b2g-bluetooth] Broadcast hfp connection status with system message

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v1 patch

I also moved some functions to BluetoothUtils

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 665869 [details] [diff] [review]
v1 patch

Review of attachment 665869 [details] [diff] [review]:
-----------------------------------------------------------------

We're gonna need to change to using addresses instead of object paths as IDs at some point, but now is probably not that point.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 665869 [details] [diff] [review]
v1 patch

Review of attachment 665869 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, also, if you're moving those functions to Utils, take them out of BluetoothDBusService.

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final version, r=qdot

https://tbpl.mozilla.org/?tree=Try&rev=ef6980d08552

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=a86b1f03ea6d

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final version, r=qdot

Comment 7

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82ee9a90351f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82ee9a90351f

Should this have a test?

Comment 9

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

None of the bluetooth stuff is really testable via normal means at the moment. We've got a bug 767598 filed for a testing framework, but there's a lot of tough choices to be made.