Closed Bug 795249 Opened 7 years ago Closed 7 years ago

[b2g-bluetooth] Broadcast hfp connection status with system message

Categories

(Core :: DOM: Device Interfaces, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: gyeh, Assigned: gyeh)

References

Details

(Whiteboard: [LOE:S])

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch v1 patch (obsolete) — Splinter Review
I also moved some functions to BluetoothUtils
Attachment #665869 - Flags: review?(kyle)
Comment on attachment 665869 [details] [diff] [review]
v1 patch

Review of attachment 665869 [details] [diff] [review]:
-----------------------------------------------------------------

We're gonna need to change to using addresses instead of object paths as IDs at some point, but now is probably not that point.
Attachment #665869 - Flags: review?(kyle) → review+
Comment on attachment 665869 [details] [diff] [review]
v1 patch

Review of attachment 665869 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, also, if you're moving those functions to Utils, take them out of BluetoothDBusService.
Attachment #666414 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/82ee9a90351f

Should this have a test?
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
None of the bluetooth stuff is really testable via normal means at the moment. We've got a bug 767598 filed for a testing framework, but there's a lot of tough choices to be made.
You need to log in before you can comment on or make changes to this bug.