B2G STK: Refactor StkCommandParamsFactory

RESOLVED FIXED in mozilla26

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: allstars, Assigned: Georgia Wang)

Tracking

Trunk
mozilla26
ARM
Gonk (Firefox OS)
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 3 obsolete attachments)

As philikon commented in Bug 793137 comment 9,
we could refactor StkCommandParamsFactory.
(Reporter)

Updated

6 years ago
Blocks: 791161
(Reporter)

Updated

5 years ago
Assignee: nobody → allstars.chh
(Assignee)

Updated

5 years ago
Assignee: allstars.chh → gwang
(Assignee)

Comment 1

5 years ago
Created attachment 790689 [details] [diff] [review]
part1: Refactore StkCommandParamsFactory.
Attachment #790689 - Flags: review?(allstars.chh)
(Assignee)

Comment 2

5 years ago
Created attachment 790691 [details] [diff] [review]
part2: Refactore StkProactiveCmdHelper.
Attachment #790691 - Flags: review?(allstars.chh)
(Assignee)

Comment 3

5 years ago
Created attachment 790693 [details] [diff] [review]
part3: Modify marionette STK tests
Attachment #790693 - Flags: review?(allstars.chh)
(Assignee)

Comment 4

5 years ago
Created attachment 790694 [details] [diff] [review]
part4: Modify xpcshell STK tests
Attachment #790694 - Flags: review?(allstars.chh)
(Reporter)

Updated

5 years ago
Attachment #790689 - Flags: review?(allstars.chh) → review+
Comment on attachment 790689 [details] [diff] [review]
part1: Refactore StkCommandParamsFactory.

Review of attachment 790689 [details] [diff] [review]:
-----------------------------------------------------------------

I notice it should be 'Refactor', not 'Refactore'.
(Reporter)

Updated

5 years ago
Attachment #790691 - Flags: review?(allstars.chh) → review+
Comment on attachment 790693 [details] [diff] [review]
part3: Modify marionette STK tests

Review of attachment 790693 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove those unneed code.

::: dom/icc/tests/marionette/test_stk_display_text.js
@@ +17,3 @@
>      is(command.options.userClear, expect.userClear, expect.name);
> +//  }
> +//  if (expect.isHighPriority) {

Remove them if not needed.

::: dom/icc/tests/marionette/test_stk_get_inkey.js
@@ +23,2 @@
>      is(command.options.isYesNoRequested, expect.isYesNoRequested, expect.name);
> +//  }

Ditto

::: dom/icc/tests/marionette/test_stk_setup_call.js
@@ +13,5 @@
>    is(command.typeOfCommand, icc.STK_CMD_SET_UP_CALL, expect.name);
>    is(command.commandQualifier, expect.commandQualifier, expect.name);
> +//  if (command.options.confirmMessage) {
> +    is(command.options.confirmMessage, expect.confirmMessage, expect.name);
> +//  }

Ditto
Attachment #790693 - Flags: review?(allstars.chh)
Comment on attachment 790694 [details] [diff] [review]
part4: Modify xpcshell STK tests

Review of attachment 790694 [details] [diff] [review]:
-----------------------------------------------------------------

You forgot 'hg add test_ril_worker_stk.js' on this patch
Attachment #790694 - Flags: review?(allstars.chh)
(Assignee)

Comment 8

5 years ago
Created attachment 791108 [details] [diff] [review]
part3: Modify marionette stk test. v2
Attachment #790693 - Attachment is obsolete: true
Attachment #791108 - Flags: review?(allstars.chh)
(Assignee)

Updated

5 years ago
Attachment #791108 - Attachment description: Bug795252_part3: marionette stk test. v2 → Bug 795252 - part 3: marionette stk test. v2
(Assignee)

Updated

5 years ago
Attachment #791108 - Attachment description: Bug 795252 - part 3: marionette stk test. v2 → part 3: Modify marionette stk test. v2
(Assignee)

Updated

5 years ago
Attachment #791108 - Attachment description: part 3: Modify marionette stk test. v2 → part3: Modify marionette stk test. v2
(Assignee)

Comment 9

5 years ago
Created attachment 791109 [details] [diff] [review]
part4: Modify xpcshell STK tests. v2
Attachment #790694 - Attachment is obsolete: true
Attachment #791109 - Flags: review?(allstars.chh)
(Reporter)

Updated

5 years ago
Attachment #791108 - Flags: review?(allstars.chh) → review+
(Reporter)

Updated

5 years ago
Attachment #791109 - Flags: review?(allstars.chh) → review+
(Assignee)

Comment 10

5 years ago
Created attachment 791180 [details] [diff] [review]
part2: Refactore StkProactiveCmdHelper. v2
Attachment #790691 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.