Closed
Bug 795252
Opened 12 years ago
Closed 11 years ago
B2G STK: Refactor StkCommandParamsFactory
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: allstars.chh, Assigned: gwang)
References
Details
Attachments
(4 files, 3 obsolete files)
|
6.28 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
|
42.84 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
|
64.77 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
|
5.90 KB,
patch
|
Details | Diff | Splinter Review |
As philikon commented in Bug 793137 comment 9,
we could refactor StkCommandParamsFactory.
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → allstars.chh
|
Assignee | |
Updated•11 years ago
|
Assignee: allstars.chh → gwang
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #790689 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #790691 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #790693 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #790694 -
Flags: review?(allstars.chh)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #790689 -
Flags: review?(allstars.chh) → review+
|
|
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 790689 [details] [diff] [review]
part1: Refactore StkCommandParamsFactory.
Review of attachment 790689 [details] [diff] [review]:
-----------------------------------------------------------------
I notice it should be 'Refactor', not 'Refactore'.
|
|
Reporter | |
Updated•11 years ago
|
Attachment #790691 -
Flags: review?(allstars.chh) → review+
|
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 790693 [details] [diff] [review]
part3: Modify marionette STK tests
Review of attachment 790693 [details] [diff] [review]:
-----------------------------------------------------------------
Please remove those unneed code.
::: dom/icc/tests/marionette/test_stk_display_text.js
@@ +17,3 @@
> is(command.options.userClear, expect.userClear, expect.name);
> +// }
> +// if (expect.isHighPriority) {
Remove them if not needed.
::: dom/icc/tests/marionette/test_stk_get_inkey.js
@@ +23,2 @@
> is(command.options.isYesNoRequested, expect.isYesNoRequested, expect.name);
> +// }
Ditto
::: dom/icc/tests/marionette/test_stk_setup_call.js
@@ +13,5 @@
> is(command.typeOfCommand, icc.STK_CMD_SET_UP_CALL, expect.name);
> is(command.commandQualifier, expect.commandQualifier, expect.name);
> +// if (command.options.confirmMessage) {
> + is(command.options.confirmMessage, expect.confirmMessage, expect.name);
> +// }
Ditto
Attachment #790693 -
Flags: review?(allstars.chh)
|
|
Reporter | |
Comment 7•11 years ago
|
||
Comment on attachment 790694 [details] [diff] [review]
part4: Modify xpcshell STK tests
Review of attachment 790694 [details] [diff] [review]:
-----------------------------------------------------------------
You forgot 'hg add test_ril_worker_stk.js' on this patch
Attachment #790694 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Attachment #790693 -
Attachment is obsolete: true
Attachment #791108 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #791108 -
Attachment description: Bug795252_part3: marionette stk test. v2 → Bug 795252 - part 3: marionette stk test. v2
|
|
Assignee | |
Updated•11 years ago
|
Attachment #791108 -
Attachment description: Bug 795252 - part 3: marionette stk test. v2 → part 3: Modify marionette stk test. v2
|
|
Assignee | |
Updated•11 years ago
|
Attachment #791108 -
Attachment description: part 3: Modify marionette stk test. v2 → part3: Modify marionette stk test. v2
|
|
Assignee | |
Comment 9•11 years ago
|
||
Attachment #790694 -
Attachment is obsolete: true
Attachment #791109 -
Flags: review?(allstars.chh)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #791108 -
Flags: review?(allstars.chh) → review+
|
|
Reporter | |
Updated•11 years ago
|
Attachment #791109 -
Flags: review?(allstars.chh) → review+
|
|
Assignee | |
Comment 10•11 years ago
|
||
Attachment #790691 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=fac9cfc98fff Try server result
|
|
Reporter | |
Comment 12•11 years ago
|
||
|
||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a3cad262ac41
https://hg.mozilla.org/mozilla-central/rev/1020cd4df1a7
https://hg.mozilla.org/mozilla-central/rev/aa56304dbe90
https://hg.mozilla.org/mozilla-central/rev/c17afbd7deb7
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•