795262 - Highlighter depends on MozAfterPaint to detect that the size or position of an element has changed

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is a problem with DLBI (bug 539356) since we never promised to fire MozAfterPaint for changes to invisible elements (and we already don't in some cases, e.g. offscreen elements). DLBI makes the browser_inspector_invalidate.js test fail because the DIV whose width is changed is invisible; nothing gets repainted, so we don't fire MozAfterPaint.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix test

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 665847 [details] [diff] [review]
fix test

There's nothing special about these changes so asking for cjones to give a quick review now.

If there are any issues, I'll fix them after this.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This patch makes the test pass, but there's still a bug where highlighting invisible elements won't necessarily update promptly when the invisible element size or position changes (and nothing else does).

Right now I'm not sure how to fix that. We don't have a good API to detect such changes. It might be good enough to simply use setTimeout or mozRequestAnimationFrame and poll for changes.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6b58397ad735

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 665847 [details] [diff] [review]
fix test

post hoc r+ from me. Thanks for this.