Replace LL_MAXINT, LL_MAXUINT and LL_MININT with INT64_MAX, UINT64_MAX and INT64_MIN

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ehsan, Assigned: isaac)

Tracking

(Blocks 1 bug)

Trunk
mozilla18
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=ehsan][lang=c++])

Attachments

(2 attachments)

This is pretty similar to bug 791906, but for 64-bit values.

Isaac, interested in taking this as well? :-)
We can also replace the function versions of these macros (LL_MaxInt, LL_MaxUint and LL_MinInt) with the stdint macros here as well (in a separate patch of course).
Assignee: nobody → isaac.aggrey
Comment on attachment 666058 [details] [diff] [review]
Replace LL_MAXINT, LL_MININT, LL_MAXUINT with stdint versions

Review of attachment 666058 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!  Can you please test it on try?
Attachment #666058 - Flags: review?(ehsan) → review+
I should've stuck both patches in one try run; first patch's results are looking green but still in progress (https://tbpl.mozilla.org/?tree=Try&rev=1a991fd3a848) and the second patch (this one) just got pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=0083adfdec5f
Attachment #666081 - Flags: review?(ehsan)
Comment on attachment 666081 [details] [diff] [review]
Replace LL_MaxInt(), LL_MinInt(), LL_MaxUint() functions with stdint macros

Review of attachment 666081 [details] [diff] [review]:
-----------------------------------------------------------------

You are quick, sir!  :-)
Attachment #666081 - Flags: review?(ehsan) → review+
I feel confident enough about these patches.  I'll just push them to inbound, and have cancelled the try pushes.
(In reply to Ehsan Akhgari [:ehsan] from comment #6)
> I feel confident enough about these patches.  I'll just push them to
> inbound, and have cancelled the try pushes.

Great, I was kinda hoping that would happen...I was feeling bad about wasting try server resources.

(In reply to Ehsan Akhgari [:ehsan] from comment #5)
> Comment on attachment 666081 [details] [diff] [review]
> Replace LL_MaxInt(), LL_MinInt(), LL_MaxUint() functions with stdint macros
> 
> Review of attachment 666081 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> You are quick, sir!  :-)

I try! Even with these simpler bugs, if I had known that I'd get such a kick out of contributing I would've started a long time ago!
Try run for 1a991fd3a848 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1a991fd3a848
Results (out of 219 total builds):
    exception: 70
    success: 141
    warnings: 6
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/isaac.aggrey@gmail.com-1a991fd3a848
Try run for 0083adfdec5f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=0083adfdec5f
Results (out of 95 total builds):
    exception: 58
    success: 37
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/isaac.aggrey@gmail.com-0083adfdec5f
Isaac, thanks a lot for your work! It's much appreciated.
(In reply to :Ms2ger from comment #12)
> Isaac, thanks a lot for your work! It's much appreciated.

It's really my pleasure. Thank you, Ehsan, and others for creating a welcoming environment. :-)
(In reply to comment #13)
> (In reply to :Ms2ger from comment #12)
> > Isaac, thanks a lot for your work! It's much appreciated.
> 
> It's really my pleasure. Thank you, Ehsan, and others for creating a welcoming
> environment. :-)

My pleasure! :-)
You need to log in before you can comment on or make changes to this bug.