MOZ_BUILD_APP is now 'mobile/android' on Fennec, yet we still do plenty of things like: 79 ifneq (mobile,$(MOZ_BUILD_APP)) 80 MOCHITEST_BROWSER_FILES = \ 81 browser_bug592641.js \ 82 bug592641_img.jpg \ 83 $(NULL) 84 endif Since nothing has blown up, I imagine most uses of |ifneq (mobile,$(MOZ_BUILD_APP))| can just be removed, since they are |if(true)| already. For those that should actually still be doing something, we need to s_mobile_mobile/android_g
I suspect these aren't a problem right now because they were only added so that we wouldn't mix desktop Firefox browser-chrome tests in with the Mobile Firefox browser-chrome tests, but we don't have browser-chrome tests at all on the new Android Firefox.
I believe you are correct :ted.
Ok, so we can just get rid of the conditionals, for those matching the pattern in comment 0 :-)
Summary: Fix or get rid of instances of "ifneq (mobile,$(MOZ_BUILD_APP))" → Remove instances of "ifneq (mobile,$(MOZ_BUILD_APP))"
Created attachment 666532 [details] [diff] [review] Patch v1
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #666532 - Flags: review?(ted.mielczarek)
Attachment #666532 - Flags: review?(ted.mielczarek) → review+
Because we're filled with awesome, you're permaorange on Android M8, because of bug 559272 comment 126.
(In reply to Phil Ringnalda (:philor) from comment #6) > Because we're filled with awesome, you're permaorange on Android M8, because > of bug 559272 comment 126. Filed bug 798806.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.