795393 - Remove instances of "ifneq (mobile,$(MOZ_BUILD_APP))"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

MOZ_BUILD_APP is now 'mobile/android' on Fennec, yet we still do plenty of things like:

79 ifneq (mobile,$(MOZ_BUILD_APP))
80 MOCHITEST_BROWSER_FILES = \
81 		browser_bug592641.js \
82 		bug592641_img.jpg \
83 		$(NULL)
84 endif

Since nothing has blown up, I imagine most uses of |ifneq (mobile,$(MOZ_BUILD_APP))| can just be removed, since they are |if(true)| already. For those that should actually still be doing something, we need to s_mobile_mobile/android_g

Comment 1

[(not currently active) Ted Mielczarek]

I suspect these aren't a problem right now because they were only added so that we wouldn't mix desktop Firefox browser-chrome tests in with the Mobile Firefox browser-chrome tests, but we don't have browser-chrome tests at all on the new Android Firefox.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I believe you are correct :ted.

Comment 3

[Ed Morley [:emorley]]

Ok, so we can just get rid of the conditionals, for those matching the pattern in comment 0 :-)

Comment 4

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8180cd29102a

Comment 6

[Phil Ringnalda (:philor)]

Because we're filled with awesome, you're permaorange on Android M8, because of bug 559272 comment 126.

Comment 7

[Ed Morley [:emorley]]

(In reply to Phil Ringnalda (:philor) from comment #6)
> Because we're filled with awesome, you're permaorange on Android M8, because
> of bug 559272 comment 126.

Filed bug 798806.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8180cd29102a