Closed Bug 795395 Opened 7 years ago Closed 7 years ago
Valgrind on tbpl detects: Invalid read of size 4 with ns
GSettings Service on the stack
Valgrind detects: Invalid read of size 4 with nsGSettingsService on the stack, see attached snippet which comes from: https://tbpl.mozilla.org/php/getParsedLog.php?id=15623197&tree=Firefox&full=1 Guessing Core: Widget: Gtk, please change component if necessary. s-s because this is an invalid read. Suspecting it is a regression from bug 713802 which itself likely comes from bug 611953.
related to https://bugzilla.mozilla.org/show_bug.cgi?id=794174 perhaps?
I guess what happens is nsGSettingsService::Init() fails because the glib version is too old for this feature, which causes us to attempt to unload the library twice (once in Init() and again in the destructor). The attached 1-liner should fix that (untested here though, because this doesn't fail on my machine)
(In reply to Chris Coulson from comment #2) > Created attachment 666001 [details] [diff] [review] > Fix invalid read in nsGSettingsService Perhaps you'd like to request for review on this patch? Although GIO landed some time ago, it was only turned on by default yesterday, so setting flags accordingly.
Since it is an arbitrary read, assuming sec-critical worse-case, unless otherwise shown.
This functionality is not really under attacker control so sec-moderate is probably more appropriate.
A type of test for this bug has already been landed because it is already marked in-testsuite+ -> VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.