795410 - [b2g-bluetooth] Implement nsIDOMBluetoothAdapter::SendFile()

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

We do have function SendFile() defined in nsIDOMBluetoothAdapter, which is not implemented yet.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: basic function prototype

Comment 2

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: v1: IPC related implementation

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 666002 [details] [diff] [review]
patch 1: v1: basic function prototype

Review of attachment 666002 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/ipc/BluetoothServiceChildProcess.cpp
@@ +323,5 @@
> +  BluetoothReplyRunnable* aRunnable)
> +{
> +  // Will implement in another patch
> +  return true;
> +}

So, just making sure, we aren't going to be shuttling ALL of the bytes back and forth between the parent and child, right?

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 3: v1: Get file content and send

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/17f579c381b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/02747dcace86
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b799e713234

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/17f579c381b1
https://hg.mozilla.org/mozilla-central/rev/02747dcace86
https://hg.mozilla.org/mozilla-central/rev/5b799e713234