795478 - DeviceStorage: freeBytes is a very large number when I use up all the space on /sdcard

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Flanagan [:djf]]

If I fill up my sdcard by writing giant files with dd, device storage stat() reports some giant number of free bytes.  If I leave just a tiny bit of free space, stat() seems to report that correctly.

I'm guessing that since adb gives me root access, I'm able to actually use up reserved space on the partition and the OS is reporting negative free bytes, which are then getting converted to an giant unsigned value.

Here's an example giant value: 18446744073709548000  It equals -3616, I think

I don't want freeBytes to return a negative value.  It should clamp to 0, I think.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[David Flanagan [:djf]]

Doug, did you intentionally leave the requestee field blank?  Your patch is r? but no one is listed to do the review.

Comment 3

[Doug Turner (:dougt)]

djf, i was looking for a reviewer last night.  I found bsmedberg. ;)


I'll check-in tonight.

Comment 4

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba388025ede9

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ba388025ede9