7955 - Component Registry file is missing type/creator info

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect, P3)

Description

[Simon Fraser [no longer active]]

The Component Registry file that gets created has no icon, because its type
and creator are blank. I guess this bug depends on 6181.

Comment 1

[Suresh Duddi (gone)]

SSSUUUURRRREEEE...

Comment 2

[mcmullen]

I doubt that dp is using nsFileSpec to create the registry, because I recall that
libreg still uses nspr paths.

Comment 3

[Suresh Duddi (gone)]

xpcom is planning on using filespec for file operations for a ton of other
reasons too. There are a few road blocks to the conversion still. I will talk
about that in the xpcom needs to use filespec bug report.

Comment 4

[Simon Fraser [no longer active]]

Why is this all platforms? Type/creator info is only present on Mac.

Comment 5

[Warren Harris]

Adding dougt -- he added support for this to nsFileSpec. (Maybe this is a dup).

Comment 6

[Suresh Duddi (gone)]

If nsIFile or whatever supports this, maybe we can use that.

Comment 7

[Doug Turner (:dougt)]

nsIFIle will support this.  

Comment 8

[Doug Turner (:dougt)]

assigning to sdagley.  Steve, could you do the QI and set in the right place??

Comment 9

[Steve Dagley]

Re-assigning to samir since the installer creates the registry

Comment 10

[Simon Fraser [no longer active]]

We need all files to have proper types/creators. Currently, .xpt files are 
missing these too.

Comment 11

[Samir Gehani]

The installer doesn't create the registry.  XPCOM's autoreg process does.  
Besides, the creator is already being set as 'MOSS' for Netscape builds which is 
correct.  Wow!  That was an easy fix :o)

Simon,
Restoration of type/creator occurs during AppleSingle decoding.  The bug is that 
the release process must set these because XPInstall is generic and can't force 
a type/creator in installed files during its extraction process.  That would be 
a bug against jj.  CC'ing him to bring this issue to his attention.

Comment 12

[J.J. Enser]

We can either
1. fix RegXPCom so that it creates the component registry using nsFileSpec, 
therefore assigning the proper file type/creator when the file is created, or

2. I can add yet another patch to the packaging system and set the Component 
Registry's type/creator before I build [xpcom.xpi]. However, if I remember 
correctly, this version of the component registry is not the one that end up on 
the user's machine, right? I thought that xpinstall was regenerating one at 
install time. If this is the case, we're back to square 1.

PS: btw, why is this bug already marked fixed?

Comment 13

[Warren Harris]

We should be using nsILocalFileMac for this. SetFileTypeAndCreator

Comment 14

[Suresh Duddi (gone)]

The lowest level before calling into OS to create the component registry is
libreg. This aint fixed. I am going to assign it to dveditz.

Comment 15

[Suresh Duddi (gone)]

Ok this is assigned to sgehani who is in the same group as dveditz. Can you
coordiate this with dan.

Comment 16

[Samir Gehani]

JJ,
This bug was marked fixed because the Component Registry being generated already 
has the creator set to 'MOSS' as I specified in my comment above.  And yes, we 
do delete the Component Registry so it can autoreg the first time.  Not sure if 
that's still the current thinking.  DP?

The bug was reopened because we were getting the 'MOSS' creator for free as teh 
default file creator.  DP's point is that we should be setting it explicitly in 
registry code.  Fair enough.

Comment 17

[Simon Fraser [no longer active]]

Also note that the creator code should be 'MOZZ" in mozilla and 'MOSS" in 
commercial. We really need some kind of service to get the app name/creator.

Comment 18

[Daniel Veditz [:dveditz]]

Resetting missed milestones

Comment 19

[Dawn Endico]

dp is no longer @netscape.com. reassigning qa contact to default for this component

Comment 20

[Samir Gehani]

-> XPCOM Registry owner for triage.

Comment 21

[Simon Fraser [no longer active]]

This file shows up as a Stuffit Archive on Mac OS X, which is certainly wrong.

Comment 22

[Conrad Carlen (not reading bugmail)]

There sure are ample methods on nsILocalFileMac for setting type/creator info.
Just a matter of finding out where to put it in the component mgr. Though the
file may be made in registry C code, I think the component mgr could find out
whether it existed before calling the registry, and if it didn't and now it
does, set the file type.

Comment 23

[Doug Turner (:dougt)]

do we really need to have a type/creator for components/compreg.dat?  What do we
do for xpti.dat?