795544 - Implement StringEncoding API in non-worker windowless context

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Some people want this feature in windowless context.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Make StringEncoding API available from xpcshell/jsm

This is an interim solution until bug 781615 is resolved.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Test update

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 666161 [details] [diff] [review]
Make StringEncoding API available from xpcshell/jsm

I assume you've verified that all globals that come through here have binding proto array set up in their slots and have the right trace hook?

If you haven't, please do.

Also, document that this is only initializing the ones we want available on all XPConnect globals.

r=me with that

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 666162 [details] [diff] [review]
Test update

r=me

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Make StringEncoding API available from xpcshell/jsm

> I assume you've verified that all globals that come through here have
> binding proto array set up in their slots and have the right trace hook?
> 
> If you haven't, please do.
I haven't, so I have done now.
The proto array would be initialized through XPCWrappedNative::WrapNewGlobal > xpc_CreateGlobalObject > AllocateProtoOrIfaceCache for JSCLASS_DOM_GLOBAL jsclasses.
All jsclasses with XPCONNECT_GLOBAL_FLAGS (which implies JSCLASS_DOM_GLOBAL) set TraceXPCGlobal as the trace hook. No other jsclasses have JSCLASS_DOM_GLOBAL (modulo DedicatedWorkerGlobalScope).
So I believe I can assume that the global is initialized correctly by the presence of MOZ_ASSERT(js::GetObjectClass(global)->flags & JSCLASS_DOM_GLOBAL). I moved GetProtoObject calls to below the assertion.
Please correct me if it is wrong. I'm not familiar with the WebIDL bindings machinery so much.

> Also, document that this is only initializing the ones we want available on
> all XPConnect globals.
Done.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 666346 [details] [diff] [review]
Make StringEncoding API available from xpcshell/jsm

Thanks for checking the setup.  Yes, that sounds reasonable.

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: Test update. r=bzbarsky

Rebased to tip. The previous patch was applied over bug 795542, but this bug got the review earlier.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

I hope that we can land this soon, as I need this feature to progress in quite a few bugs.

Comment 9

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=1df171d068bd

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d4bafc6c481
https://hg.mozilla.org/integration/mozilla-inbound/rev/3afaf5133bec

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1d4bafc6c481
https://hg.mozilla.org/mozilla-central/rev/3afaf5133bec