Closed Bug 795571 Opened 7 years ago Closed 7 years ago

Various nsIChannel consumers are checking for private browsing incorrectly

Categories

(Core :: ImageLib, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: jdm, Assigned: jdm)

References

Details

Attachments

(1 file)

There are several places in the code that are still using the old style of obtaining the callbacks and querying the loadcontext status. Since the introduction of nsIPrivateBrowsingChannel this is now potentially incorrect.
Blocks: PBnGen
Although this is content/ and image/ code, I feel like it makes more sense for you to sign off on these changes.
Attachment #666184 - Flags: review?(jduell.mcbugs)
Comment on attachment 666184 [details] [diff] [review]
Update nsIChannel consumers concerned with privacy status to use the correct NS_UsePrivateBrowsing.

Review of attachment 666184 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing.  r=me
Attachment #666184 - Flags: review?(jduell.mcbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/56885f7a48b6
Assignee: nobody → josh
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.