Closed
Bug 795571
Opened 12 years ago
Closed 12 years ago
Various nsIChannel consumers are checking for private browsing incorrectly
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: jdm, Assigned: jdm)
References
Details
Attachments
(1 file)
|
4.07 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
There are several places in the code that are still using the old style of obtaining the callbacks and querying the loadcontext status. Since the introduction of nsIPrivateBrowsingChannel this is now potentially incorrect.
|
Assignee | |
Comment 1•12 years ago
|
||
Although this is content/ and image/ code, I feel like it makes more sense for you to sign off on these changes.
Attachment #666184 -
Flags: review?(jduell.mcbugs)
|
||
Updated•12 years ago
|
Blocks: pbchannelfail
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 666184 [details] [diff] [review]
Update nsIChannel consumers concerned with privacy status to use the correct NS_UsePrivateBrowsing.
Review of attachment 666184 [details] [diff] [review]:
-----------------------------------------------------------------
Stealing. r=me
Attachment #666184 -
Flags: review?(jduell.mcbugs) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Assignee: nobody → josh
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•