Closed Bug 795580 Opened 12 years ago Closed 12 years ago

Stub shouldn't be copied when it isn't built (regression from bug 322206)

Categories

(Toolkit Graveyard :: Build Config, defect)

Product:
Toolkit Graveyard
Component:
Build Config
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: regression, Whiteboard: [qa-])

Attachments

(1 file)

patch rev1
1.40 KB, patch
bbondy
: review+
Details | Diff | Splinter Review 
Spinoff of bug 322206 comment #156

Robert: Can/should those two lines in makensis.mk also be ifdef_ed with MOZ_STUB_INSTALLER?
"+	cp $(CONFIG_DIR)/stub.exe "$(DIST)/$(PKG_INST_PATH)$(PKG_INST_BASENAME)-stub.exe"
+	chmod 0755 "$(DIST)/$(PKG_INST_PATH)$(PKG_INST_BASENAME)-stub.exe""

At least the SeaMonkey build does not like that as it does not build the stub installer. I guess Thunderbird has the same problem.
Attached patch patch rev1 — — Splinter Review 
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED

        Attachment #666192 -
        Flags: review?(netzen)

        Attachment #666192 -
        Flags: review?(netzen) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/1f7dbc3b3baf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18

    
    

    
  
Thanks for the quick fix!
Whiteboard: [qa-]

    
  
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: