Closed Bug 795627 Opened 9 years ago Closed 5 years ago
[Skia] Allow the Skia canvas backend to be used on accelerated Windows
58 bytes, text/x-review-board-request
Currently, BACKEND_SKIA is only added to the allowable backends bitmask if direct2d is disabled. I think we should allow Skia to be usable on machines that are accelerated as well.
Oh, hrm, text doesn't currently work in Skia/Canvas if Direct2D is enabled.
5 years ago
Attachment #666234 - Attachment is obsolete: true
Comment on attachment 8818734 [details] Bug 795627: Allow Skia canvas with accelerated Windows. https://reviewboard.mozilla.org/r/98686/#review99016
Attachment #8818734 - Flags: review?(gwright) → review+
5 years ago
Assignee: nobody → milan
(In reply to Milan Sreckovic [:milan] from comment #5) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=790ec47c7196f041a8461f43b4763355ab23068e A couple of intermittent oranges, I don't imagine would get more frequent with this patch.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/11e2a07abdaa Allow Skia canvas with accelerated Windows. r=gw280
Milan, does this fix have automated coverage? Would it benefit from manual testing as well?
There are automated tests, but I don't think we run this configuration by default, so doing manual testing may be useful. Kats, can you do a try push with the preference disabling D2D content/canvas, just to see if something unexpected is happening? Still with the accelerated compositor.
Flags: needinfo?(milan) → needinfo?(bugmail)
I think this should do it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c4a4c042d2db1609e0b07e777f001fc028ec843 Leaving needinfo on me until the try push is done.
Try results are in. There's gpu job failures, but that's expected (it's asserting D2D is on but it's not). And then there's a handful of WPT tests that are passing instead of failing, so those jobs are failing with TEST-UNEXPECTED-PASS. There's one test which changed from a pass to a fail. I haven't looked at the tests so I'm not sure what they're doing, but overall it doesn't seem like there's a lot of unexpected bustage.
You need to log in before you can comment on or make changes to this bug.