795627 - [Skia] Allow the Skia canvas backend to be used on accelerated Windows

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[George Wright (:gw280) (needinfo me!)]

Currently, BACKEND_SKIA is only added to the allowable backends bitmask if direct2d is disabled. I think we should allow Skia to be usable on machines that are accelerated as well.

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: Add BACKEND_SKIA to the bitmask

Comment 2

[George Wright (:gw280) (needinfo me!)]

Oh, hrm, text doesn't currently work in Skia/Canvas if Direct2D is enabled.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 795627: Allow Skia canvas with accelerated Windows.

Review commit: https://reviewboard.mozilla.org/r/98686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98686/

Comment 4

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8818734 [details]
Bug 795627: Allow Skia canvas with accelerated Windows.

https://reviewboard.mozilla.org/r/98686/#review99016

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=790ec47c7196f041a8461f43b4763355ab23068e

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Milan Sreckovic [:milan] from comment #5)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=790ec47c7196f041a8461f43b4763355ab23068e

A couple of intermittent oranges, I don't imagine would get more frequent with this patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11e2a07abdaa
Allow Skia canvas with accelerated Windows. r=gw280

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11e2a07abdaa

Comment 9

[Andrei Vaida [:avaida]]

Milan, does this fix have automated coverage? Would it benefit from manual testing as well?

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

There are automated tests, but I don't think we run this configuration by default, so doing manual testing may be useful.  Kats, can you do a try push with the preference disabling D2D content/canvas, just to see if something unexpected is happening?  Still with the accelerated compositor.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

I think this should do it:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c4a4c042d2db1609e0b07e777f001fc028ec843

Leaving needinfo on me until the try push is done.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Try results are in. There's gpu job failures, but that's expected (it's asserting D2D is on but it's not). And then there's a handful of WPT tests that are passing instead of failing, so those jobs are failing with TEST-UNEXPECTED-PASS. There's one test which changed from a pass to a fail. I haven't looked at the tests so I'm not sure what they're doing, but overall it doesn't seem like there's a lot of unexpected bustage.