795658 - Assertion failure: _mOwningThread.GetThread() == PR_GetCurrentThread() (GonkGPSGeolocationProvider not thread-safe), at dom/system/gonk/GonkGPSGeolocationProvider.cpp:40

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Open the camera in a debug build

I'm not sure where this assertion is coming from.

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

hmm.. line 40 is

  NS_IMPL_ISUPPORTS2(GonkGPSGeolocationProvider, nsIGeolocationProvider, nsIRILDataCallback)

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

If this class really is threadsafe, that should be

  NS_IMPL_THREADSAFE_ISUPPORTS2(...)

or the threadsafe warning will trigger on every AddRef/Release.

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Make sure most methods are running from main thread

While most of the methods should run from main thread, we deliberately put Init and ShutdownGPS to the other thread to prevent blocking.

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d6caa803dca

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3d6caa803dca