Closed Bug 795658 Opened 7 years ago Closed 7 years ago

Assertion failure: _mOwningThread.GetThread() == PR_GetCurrentThread() (GonkGPSGeolocationProvider not thread-safe), at dom/system/gonk/GonkGPSGeolocationProvider.cpp:40

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: cjones, Assigned: kanru)

Details

Attachments

(1 file)

STR
 (1) Open the camera in a debug build

I'm not sure where this assertion is coming from.
hmm.. line 40 is

  NS_IMPL_ISUPPORTS2(GonkGPSGeolocationProvider, nsIGeolocationProvider, nsIRILDataCallback)
If this class really is threadsafe, that should be

  NS_IMPL_THREADSAFE_ISUPPORTS2(...)

or the threadsafe warning will trigger on every AddRef/Release.
Assignee: nobody → kchen
While most of the methods should run from main thread, we deliberately put Init and ShutdownGPS to the other thread to prevent blocking.
Attachment #667347 - Flags: review?(doug.turner)
Attachment #667347 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/3d6caa803dca
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.