If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Setting network.activity.blipIntervalMilliseconds in the user pref should make network blip notifications being sent

RESOLVED FIXED in mozilla18

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Blocks: 1 bug)

Trunk
mozilla18
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Right now, if network.activity.blipIntervalMilliseconds is set as a user_pref(), it does nothing. The only way to have the value taken into consideration is to have it set as a pref(). Unfortunately, this prevents tests for bug 795136 to run.
(Assignee)

Comment 1

5 years ago
This should block because it prevents us from testing the feature.
blocking-basecamp: --- → ?
(Assignee)

Updated

5 years ago
Blocks: 795716
(Assignee)

Comment 2

5 years ago
Created attachment 666332 [details] [diff] [review]
Patch

This patch makes us wait for the profile to be read before starting the network montioring. That way, we can read the user pref.
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #666332 - Flags: review?(michal.novotny)
Comment on attachment 666332 [details] [diff] [review]
Patch

r=me
Attachment #666332 - Flags: review?(michal.novotny) → review+
(Assignee)

Comment 4

5 years ago
Sent to try with other patches:
https://tbpl.mozilla.org/?tree=Try&rev=6a6690d20239
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7df09766614

This is going to be tested by bug 795716.
Target Milestone: --- → mozilla18
blocking-basecamp: ? → +
https://hg.mozilla.org/mozilla-central/rev/c7df09766614

Should this have a test?
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.