795711 - Setting network.activity.blipIntervalMilliseconds in the user pref should make network blip notifications being sent

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Mounir Lamouri (:mounir)]

Right now, if network.activity.blipIntervalMilliseconds is set as a user_pref(), it does nothing. The only way to have the value taken into consideration is to have it set as a pref(). Unfortunately, this prevents tests for bug 795136 to run.

Comment 1

[Mounir Lamouri (:mounir)]

This should block because it prevents us from testing the feature.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch

This patch makes us wait for the profile to be read before starting the network montioring. That way, we can read the user pref.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 666332 [details] [diff] [review]
Patch

r=me

Comment 4

[Mounir Lamouri (:mounir)]

Sent to try with other patches:
https://tbpl.mozilla.org/?tree=Try&rev=6a6690d20239

Comment 5

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7df09766614

This is going to be tested by bug 795716.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c7df09766614

Should this have a test?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

https://searchfox.org/mozilla-central/source/dom/tests/mochitest/general/mochitest.ini#123 says:

[test_network_events.html]
skip-if = true
# Disable this test until bug 795711 is fixed.

this bug is fixed, :jesup, as triage owner can you [find someone to] try re-enabling this test and either get it going or not. It has been disabled for 11+ years which is sort of pointless to keep it around.

Comment 8

[Mathew Hodson]

(In reply to Joel Maher ( :jmaher ) (UTC -8) from comment #7)

this bug is fixed, :jesup, as triage owner can you [find someone to] try re-enabling this test and either get it going or not.

It looks like bug 795716 is for re-enabling the test.