Closed Bug 795711 Opened 7 years ago Closed 7 years ago

Setting network.activity.blipIntervalMilliseconds in the user pref should make network blip notifications being sent

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: mounir, Assigned: mounir)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now, if network.activity.blipIntervalMilliseconds is set as a user_pref(), it does nothing. The only way to have the value taken into consideration is to have it set as a pref(). Unfortunately, this prevents tests for bug 795136 to run.
This should block because it prevents us from testing the feature.
blocking-basecamp: --- → ?
Blocks: 795716
Attached patch PatchSplinter Review
This patch makes us wait for the profile to be read before starting the network montioring. That way, we can read the user pref.
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #666332 - Flags: review?(michal.novotny)
Comment on attachment 666332 [details] [diff] [review]
Patch

r=me
Attachment #666332 - Flags: review?(michal.novotny) → review+
Sent to try with other patches:
https://tbpl.mozilla.org/?tree=Try&rev=6a6690d20239
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7df09766614

This is going to be tested by bug 795716.
Target Milestone: --- → mozilla18
blocking-basecamp: ? → +
https://hg.mozilla.org/mozilla-central/rev/c7df09766614

Should this have a test?
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.