Last Comment Bug 795736 - Silence some [-Wunused-variable] warnings in mailnews/
: Silence some [-Wunused-variable] warnings in mailnews/
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 18.0
Assigned To: Stefan [:stefanh] (away until May 28)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-30 11:09 PDT by Stefan [:stefanh] (away until May 28)
Modified: 2012-09-30 12:45 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Remove unused variables (6.52 KB, patch)
2012-09-30 11:09 PDT, Stefan [:stefanh] (away until May 28)
neil: review+
Details | Diff | Review

Description Stefan [:stefanh] (away until May 28) 2012-09-30 11:09:01 PDT
Created attachment 666350 [details] [diff] [review]
Remove unused variables

imap/src/nsImapMailFolder.cpp:1290:12: warning: unused variable 'rv' [-Wunused-variable]
imap/src/nsImapMailFolder.cpp:2755:10: warning: unused variable 'created' [-Wunused-variable]
imap/src/nsImapMailFolder.cpp:3445:13: warning: unused variable 'newFlags' [-Wunused-variable]
imap/src/nsImapProtocol.cpp:8485:10: warning: unused variable 'deltaTime' [-Wunused-variable]
imap/src/nsImapUndoTxn.cpp:632:12: warning: unused variable 'hdrKey' [-Wunused-variable]
local/src/nsLocalMailFolder.cpp:1018:8: warning: unused variable 'folderEmpty' [-Wunused-variable]
mime/src/mimemalt.cpp:192:48: warning: unused variable 'in_attach' [-Wunused-variable]
mime/src/mimemoz2.cpp:700:13: warning: unused variable 'res' [-Wunused-variable]
Comment 1 Stefan [:stefanh] (away until May 28) 2012-09-30 11:12:49 PDT
(there are actually a few more, but I'll leave them for now)
Comment 2 neil@parkwaycc.co.uk 2012-09-30 12:28:52 PDT
Comment on attachment 666350 [details] [diff] [review]
Remove unused variables

>-            // msgHdr->OrFlags(nsMsgMessageFlags::Read, &newFlags);  // mark read in trash.
Please don't remove this. r=me with that fixed.
Comment 3 Stefan [:stefanh] (away until May 28) 2012-09-30 12:45:25 PDT
http://hg.mozilla.org/comm-central/rev/6140a6730c83 (comment #2 addressed)

Note You need to log in before you can comment on or make changes to this bug.