795737 - "Assertion `! _cairo_surface_has_snapshots (surface)' failed. " after Bug 486918 fixed

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[ojab]

Attachment: gdb bt full

I'm getting crashes with 
firefox: cairo-surface.c:1463: cairo_surface_mark_dirty_rectangle: Assertion `! _cairo_surface_has_snapshots (surface)' failed.

on changeset 108670:27e0c22b96e5 (mozilla-inbound tree) and above, build with system cairo-1.12.2 & cairo-git.
Fx built with bundled cairo doesn't crashes.

You can find `gdb bt full` (using cairo-git) in the attached file.
Please note that --enable-system-cairo is broken, patch can be found in Bug 722975.

Comment 1

[Joe Drew (not getting mail)]

Can you give me an example of a testcase that causes this assertion failure?

Comment 2

[ojab]

Yes, first testcase for Bug 486918 works (in URL, https://bug486918.bugzilla.mozilla.org/attachment.cgi?id=428179).
Page load leads to assertion in 100% cases for me.

Comment 3

[Joe Drew (not getting mail)]

Sorry, missed that somehow.

I can reproduce this bug. I'll investigate it.

Comment 4

[Joe Drew (not getting mail)]

Attachment: flush in unlock

In lieu of implementing bug 797083 in full, let's just Flush in MarkDirty too.

Comment 5

[Bas Schouten (:bas.schouten)]

Comment on attachment 667130 [details] [diff] [review]
flush in unlock

Review of attachment 667130 [details] [diff] [review]:
-----------------------------------------------------------------

Some FIXME or something would be nice ;) Or a reference to bug 797083.

Comment 6

[ojab]

Bug 722975 is finally going to be fixed in mozilla-central (patch already passed try build and applied to mozilla-inbound), after that mozilla-central will be buildable with system cairo out of the box again.

Can this patch be applied in the current form (so I'll set [checkin-needed]) or additional FIXME is a must?
If so — Joe, can you make this changes?

Comment 7

[Joe Drew (not getting mail)]

I think I'm actually going to fix this by fixing bug 797083, but I'll try to do that very very soon.

Comment 8

[Joe Drew (not getting mail)]

Well, so much for that. I'm going to land this patch in order to fix this very assertion, caused by patches in bug 717872.

Comment 9

[Joe Drew (not getting mail)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8e2e52c72e42

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8e2e52c72e42