795811 - Make GetPrimaryScrollableLayer() return null on all configurations except MOZ_WIDGET_ANDROID

Status: RESOLVED INVALID

(Core :: Graphics: Layers, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

See bug 790508.  This is a bad assumption that just burned us.

assign -> dz to do the honors.

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 666629 [details] [diff] [review]
Patch

>From: David Zbarsky <[e-mail]>
>Bug 795811 - Make GetPrimaryScrollableLayer() return null on all configurations except MOZ_WIDGET_ANDROID r=cjones
>
>diff --git a/gfx/layers/Layers.cpp b/gfx/layers/Layers.cpp

> // LayerManager
> Layer*
> LayerManager::GetPrimaryScrollableLayer()
> {
>+

Remove this newline.

>+#ifndef MOZ_WIDGET_ANDROID
>+  return nullptr;

Add a comment why this method is fennec-android-specific.

Comment 3

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/17f942846b9f

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Backed out in

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac380af56c49

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Once we switch fennec to APZ we can just get rid of GetPrimaryScrollableLayer entirely.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 7

[Gregory Pappas [:gregp]]

This method was replaced in bug 1055760.