Open Bug 795811 Opened 7 years ago Updated 5 years ago

Make GetPrimaryScrollableLayer() return null on all configurations except MOZ_WIDGET_ANDROID

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

People

(Reporter: cjones, Assigned: dzbarsky)

References

Details

Attachments

(1 file)

See bug 790508.  This is a bad assumption that just burned us.

assign -> dz to do the honors.
Attached patch PatchSplinter Review
Attachment #666629 - Flags: review?(jones.chris.g)
Comment on attachment 666629 [details] [diff] [review]
Patch

>From: David Zbarsky <dzbarsky@gmail.com>
>Bug 795811 - Make GetPrimaryScrollableLayer() return null on all configurations except MOZ_WIDGET_ANDROID r=cjones
>
>diff --git a/gfx/layers/Layers.cpp b/gfx/layers/Layers.cpp

> // LayerManager
> Layer*
> LayerManager::GetPrimaryScrollableLayer()
> {
>+

Remove this newline.

>+#ifndef MOZ_WIDGET_ANDROID
>+  return nullptr;

Add a comment why this method is fennec-android-specific.
Attachment #666629 - Flags: review?(jones.chris.g) → review+
Once we switch fennec to APZ we can just get rid of GetPrimaryScrollableLayer entirely.
Depends on: apz-fennec
You need to log in before you can comment on or make changes to this bug.