795813 - NPE in org.mozilla.javascript.regexp.NativeRegExp.reportWarning

Status: RESOLVED INACTIVE

(Rhino Graveyard :: Core, defect)

Description

[Michael[tm] Smith [:sideshowbarker]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.10 Safari/537.11

Steps to reproduce:

Called compileRegExp(Context cx, String source, String flags) on instance of org.mozilla.javascript.regexp.RegExpImpl with null Context.


Actual results:

NPE in org.mozilla.javascript.regexp.NativeRegExp.reportWarning


Expected results:

compileRegExp should gracefully handle the null-Context case.

I guess that means the conditional in reportWarning(Context cx, String messageId, String arg) should probably have a null check:

  if (cx != null || cx.hasFeature(Context.FEATURE_STRICT_MODE))

Comment 1

[Michael[tm] Smith [:sideshowbarker]]

(In reply to Michael[tm] Smith from comment #0)
>   if (cx != null || cx.hasFeature(Context.FEATURE_STRICT_MODE))

er, of course that'd need to be && instead of || ...

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Closing. Bug management is now done here:
https://github.com/mozilla/rhino