Cannot build with Visual Studio 2008SP1 (VC9) since Bug 486918

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: philip.chee, Assigned: Ms2ger)

Tracking

Trunk
mozilla18
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
Windows7 + Visual Studio 2008SP1:

So I'm getting the following build error:

make.py[1]: Entering directory 'c:\t1\hg\objdir-sm\mozilla\gfx\2d'
convolver.cpp
c:\t1\hg\comm-central\mozilla\config\rules.mk:981:0$ cl InvokeClWithDependencyGeneration cl -Foconvo
lver.obj -c -D_HAS_EXCEPTIONS=0 -I../../dist/stl_wrappers  -DMOZ_GFX -DUSE_CAIRO -DGFX2D_INTERNAL -D
USE_SKIA -DSK_A32_SHIFT=24 -DSK_R32_SHIFT=16 -DSK_G32_SHIFT=8 -DSK_B32_SHIFT=0 -DUSE_SSE2 -DWIN32 -D
INITGUID -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_
IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DMOZ_SUITE=1  -Ic:/t1/hg/comm-central/moz
illa/gfx/2d -I. -I../../dist/include  -Ic:/t1/hg/objdir-sm/mozilla/dist/include/nspr -Ic:/t1/hg/objd
ir-sm/mozilla/dist/include/nss        -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4800 -we4553 -GR-  -DN
DEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O1 -Oy -Ic:/t1/hg/objdir-sm/mozilla/dist/include/cairo  -MD
         -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT  c:/t1/hg/comm-central/mozilla/gfx
/2d/convolver.cpp
convolver.cpp
C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\INCLUDE\typeinfo(139) : warning C4275: non dll
-interface class 'stdext::exception' used as base for dll-interface class 'std::bad_cast'
        C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\INCLUDE\exception(241) : see declarati
on of 'stdext::exception'
        C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\INCLUDE\typeinfo(138) : see declaratio
n of 'std::bad_cast'
C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\INCLUDE\typeinfo(160) : warning C4275: non dll
-interface class 'stdext::exception' used as base for dll-interface class 'std::bad_typeid'
        C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\INCLUDE\exception(241) : see declarati
on of 'stdext::exception'
        C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\INCLUDE\typeinfo(159) : see declaratio
n of 'std::bad_typeid'
c:\t1\hg\comm-central\mozilla\gfx\2d\basictypes.h(45) : fatal error C1083: Cannot open include file:
 'stdint.h': No such file or directory

Looking at https://hg.mozilla.org/mozilla-central/rev/a59944cc3781#l5.47 I see:

    5.47 +#ifndef COMPILER_MSVC
    5.48 +// stdint.h is part of C99 but MSVC doesn't have it.
    5.49 +#include <stdint.h>         // For intptr_t.
    5.50 +#endif

So where is COMPILER_MSVC defined?
Also this whole chunk could possibly be replaced by
#include "mozilla/StandardInteger.h"
https://hg.mozilla.org/mozilla-central/rev/a17579743ac9
https://hg.mozilla.org/mozilla-central/rev/e352d9f243e7
Assignee: nobody → Ms2ger
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
I've relanded bug 486918. Let me know if it's still an issue with MSVC 2008.
You need to log in before you can comment on or make changes to this bug.