Closed Bug 795897 Opened 7 years ago Closed 7 years ago

Force NSPR logging for cache module in release build

Categories

(Core :: Networking: Cache, defect)

11 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: michal, Assigned: michal)

Details

Attachments

(2 files)

Attached patch fixSplinter Review
No description provided.
Attachment #666530 - Flags: review?(honzab.moz)
Attachment #666530 - Flags: review?(honzab.moz) → review+
Michal,

Note that the PR_LOG stuff gets really hacky if your source files include anything that winds up #including e10s stuff (as nsCacheService.cpp does):  if you #include any file that transitively includes anything e10s-related, we wind up #including prlog.h via some chromium headers, and if your own PR_FORCE_LOG happens after that, it's too late to affect logging, and it silently doesn't work (or a per-file basis: yummy!).

It looks like you're OK for now since nsCacheService.cpp includes nsCache.h before it includes #NeckoCommon.h, but you might want to consider implementing the scheme I did in nsHttp.h to make sure you get a compiler error if your PR_FORCE_LOG is ever hidden this way.  See the comment in nsHttp.h and bug 545995).
https://hg.mozilla.org/mozilla-central/rev/5ffc03e9be82
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Attached patch patch v2 - fixSplinter Review
(In reply to Jason Duell (:jduell) from comment #2)
> It looks like you're OK for now since nsCacheService.cpp includes nsCache.h
> before it includes #NeckoCommon.h

The patch didn't work correctly. Logs from some files were missing.
Attachment #683946 - Flags: review?(jduell.mcbugs)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #683946 - Flags: review?(jduell.mcbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/ea05f68a0c2c
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.