795897 - Force NSPR logging for cache module in release build

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Michal Novotny [:michal]]

Attachment: fix

Comment 1

[Michal Novotny [:michal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ffc03e9be82

Comment 2

[Jason Duell]

Michal,

Note that the PR_LOG stuff gets really hacky if your source files include anything that winds up #including e10s stuff (as nsCacheService.cpp does):  if you #include any file that transitively includes anything e10s-related, we wind up #including prlog.h via some chromium headers, and if your own PR_FORCE_LOG happens after that, it's too late to affect logging, and it silently doesn't work (or a per-file basis: yummy!).

It looks like you're OK for now since nsCacheService.cpp includes nsCache.h before it includes #NeckoCommon.h, but you might want to consider implementing the scheme I did in nsHttp.h to make sure you get a compiler error if your PR_FORCE_LOG is ever hidden this way.  See the comment in nsHttp.h and bug 545995).

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5ffc03e9be82

Comment 4

[Michal Novotny [:michal]]

Attachment: patch v2 - fix

(In reply to Jason Duell (:jduell) from comment #2)
> It looks like you're OK for now since nsCacheService.cpp includes nsCache.h
> before it includes #NeckoCommon.h

The patch didn't work correctly. Logs from some files were missing.

Comment 5

[Michal Novotny [:michal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea05f68a0c2c

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ea05f68a0c2c