795961 - chrome-document-global-created may fire for the initial about:blank load in a docshell

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[(no longer active)]

See bug 608669 comment 13 onwards.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 701185 [details] [diff] [review]
Patch (v1)

You're not checking that the about:blank is the initial about:blank document.

(And IMO this is wrong approach anyway. What if there won't be anything else but the initial document. )

Comment 3

[(no longer active)]

How can I check for whether this is the initial about:blank?

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to :Ehsan Akhgari from comment #3)
> How can I check for whether this is the initial about:blank?

nsIDocument::IsInitialDocument().

Comment 5

[Henri Sivonen (:hsivonen)]

IIRC, the parser-created about:blank isn’t considered “initial”. The docshell created doc is. Here be dragons.

Comment 6

[(no longer active)]

Attachment: Patch (v2)

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 701940 [details] [diff] [review]
Patch (v2)

I still don't understand this.
We should notify about *-document-global-created
when such global is created.

There are cases when stop is called immediately after creating an
iframe.

Comment 8

[(no longer active)]

OK, I give up.  Please see bug 608669 comment 15 on what kinds of problems the current code creates.  If you open a new browser window for example, you do not expect to receive a notification for about:blank.

I'll leave it to Benoit to figure out what you want to see happen here, but the current behavior is clearly wrong.

Comment 9

[Henri Sivonen (:hsivonen)]

I would not be at all surprised if this turned out to be unfixable without fixing bug 543435 first.

Comment 10

[(no longer active)]

Bug 829360 is another example where we were about to put some bugs in Firefox by using chrome-document-global-created.

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.