795973 - Add a pref for reader mode

Status: RESOLVED DUPLICATE of bug 795981

(Firefox :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

For desktop reader mode, there should be a pref that controls the visibility of the feature.

This pref should be added to browser/app/profile/firefox.js, named reader.enabled and the default value should be false.

Comment 1

[Chelsea Carr]

Attachment: Kevin Added a preference to enable reader mode

Kevin's patch wasn't showing up on his computer, so we just added it through mine.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 668982 [details] [diff] [review]
Kevin Added a preference to enable reader mode

This looks fine but there are a few issues with it:

1) This pref should be located at the bottom of firefox.js. There doesn't appear to be a set order for new and independent preferences, but the top is probably the least favored place to put it.
2) The patch summary needs to be more descriptive.
3) You should include 8 lines of context for your patches.

See https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch and https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in for more information.

Comment 3

[:Margaret Leibovic]

Jared, should this pref just control whether or not the reader mode toolbar button is visible (bug 795981), or are there other things we should hide behind this, like allowing users to even type about:reader in the urlbar?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

I don't think we should worry about people manually typing in about:reader. As long as the pref controls the visibility of all access points that a non-wizard could venture to then we should be covered.

Comment 5

[:Margaret Leibovic]

Cool, I think that makes sense.

I'm just going to dupe this to bug 795981, since this pref isn't useful until we add that button, and it should be simple enough to include the pref when I land the button, since I'll probably want to land it pref'ed off.