Last Comment Bug 795997 - Silence remaining[-Wunused-variable] / [-Wunused-private-field] warnings in mailnews/
: Silence remaining[-Wunused-variable] / [-Wunused-private-field] warnings in m...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 18.0
Assigned To: Stefan [:stefanh]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-01 10:46 PDT by Stefan [:stefanh]
Modified: 2012-10-01 12:42 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Silence the last ones (3.89 KB, patch)
2012-10-01 10:46 PDT, Stefan [:stefanh]
neil: review+
bugmail: review+
Details | Diff | Review

Description Stefan [:stefanh] 2012-10-01 10:46:33 PDT
Created attachment 666611 [details] [diff] [review]
Silence the last ones
Comment 1 neil@parkwaycc.co.uk 2012-10-01 11:46:32 PDT
Comment on attachment 666611 [details] [diff] [review]
Silence the last ones

You should really get someone else to review the gloda changes.
Comment 2 Stefan [:stefanh] 2012-10-01 12:13:07 PDT
Comment on attachment 666611 [details] [diff] [review]
Silence the last ones

asuth, mind looking at the changes in nsGlodaRankerFunction.cpp?
Comment 3 Andrew Sutherland [:asuth] 2012-10-01 12:31:18 PDT
Comment on attachment 666611 [details] [diff] [review]
Silence the last ones

Thanks for fixing the warnings!
Comment 4 Stefan [:stefanh] 2012-10-01 12:42:12 PDT
http://hg.mozilla.org/comm-central/rev/1f8249cc26ca

Note You need to log in before you can comment on or make changes to this bug.